hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Mar 2023
1:39 pm

Michael Garthwaite

11:25 am

Dara Navaei

11:25 am

wbracken  (deleted user) and Sean Nash

Monday 06 Mar 2023
4:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

Fixed.

Fixed.

11:36 am

Sean Nash

Fixed.

Fixed.

10:12 am

jtaylor  (deleted user)

Done.

Done.

10:03 am

Sean Nash

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm. And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm. D...

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm.
And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm.
Did Systems want to separate these? My understanding was not to separate.

9:52 am

Sean Nash

Add blank line before return.

Add blank line before return.

9:42 am

jtaylor  (deleted user)

9:41 am

jtaylor  (deleted user)

Friday 03 Mar 2023
2:54 pm

jtaylor  (deleted user)

2:45 pm

Michael Garthwaite

Thursday 02 Mar 2023
12:01 pm

Dara Navaei

HD-DEN-14834_RO Flow Drops TO Zero And CP Measured Speed 1500 Temporarily During Pre Treatment
HD-DEN-14834_RO Flow Drops TO Zero And CP Measured Speed 1500 Temporarily During Pre Treatment
Wednesday 01 Mar 2023
4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

2:01 pm

Dara Navaei

HD-DEN-14689_Messaging Bugs_MSG_ID_HD_POST_FINAL_TEST_RESULT_fix
HD-DEN-14689_Messaging Bugs_MSG_ID_HD_POST_FINAL_TEST_RESULT_fix
Tuesday 28 Feb 2023
11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

I don't think it's necessary - but I'm ok with either location for declaration. RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration.
RESOLVED in CODE WALKTHROUGH.

9:38 am

jtaylor  (deleted user)

1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state mac...

1. Style, and preference to keep loop control at the top, not buried in the state function.
2. Keep stack size for the state function more predictable.
3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state

Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.

9:24 am

jtaylor  (deleted user)

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

Monday 27 Feb 2023
4:01 pm

Dara Navaei

HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
11:40 am

Sean Nash

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide ...

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.

11:37 am

Michael Garthwaite

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

11:30 am

Sean Nash

I thought the non-safety temp alarms had a large persistence. Now they have none?

I thought the non-safety temp alarms had a large persistence. Now they have none?

11:27 am

Sean Nash

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

11:03 am

Sean Nash

Why move this?

Why move this?

10:59 am

Sean Nash

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH