Activity hdfirmware/

9:01 am

Michael Garthwaite

More
1566855
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more HD-DEN-14689-1

Merge branch 'staging' into DEN-14689-messaging-bugs

- -13
- +48
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -5
- +5
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

4:55 pm

Michael Garthwaite

More
Re: HD-DEN-14830-2
replied to Sean Nash

Fixed?

4:53 pm

Michael Garthwaite

More
Re: HD-DEN-14830-2
replied to Sean Nash

To answer this and comment below: above_high_safety_range = temp > 46 above_low_safety_range = temp > 42 above_target_temp = target + 4 below_target_temp = target - 4 below_low_safety_range = temp...

To answer this and comment below:

above_high_safety_range = temp > 46
above_low_safety_range = temp > 42
above_target_temp = target + 4
below_target_temp = target - 4
below_low_safety_range = temp < 33

I did not see any specification regarding to separate or not to separate. Original functionality had separate triggers. Respective PRS's state OR between the two triggers.
I think it would be clear to for us in terms of debugging to see which alarm is triggered since on the low side, temp - 4 would be lower than 33, (31).

Wording may be unclear. Im up for suggestions to help clarify the alarm differences.

4:42 pm

Michael Garthwaite

More
Re: HD-DEN-14830-2
replied to Sean Nash

Fixed. Thanks!

4:35 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

Shouldnt this be set to 0U instead of 0.0F?

4:35 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

This should be U32.

4:35 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

This should be U32.

4:34 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

4:33 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

4:32 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

Should we check for stall in bolus & continuous states?

4:27 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

4:25 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

Shouldnt this be set to 0U instead of 0.0F?

4:01 pm

Dara Navaei

More
HD-DEN-14906-1
started review

HD-DEN-14906_Dialyzer DE Prime

3:47 pm

Dara Navaei

More
6c966cd
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

3:40 pm

Sean Nash

More
f5e10b2
changed 5 files
develop

Fixed merge conflict.

- -10
- +33
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -13
- +3
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -6
- +5
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -0
- +8
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

3:14 pm

Dara Navaei

More
dd01205
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

3:13 pm

Michael Garthwaite

More
1cbf981
changed 5 files
develop

Merge branch 'DEN-14830-incorrect-dialysate-temperature-alarm-triggered' into develop

- -20
- +53
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -11
- +12
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -6
- +10
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -13
- +48
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

3:13 pm

Michael Garthwaite

More
f4855e9
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more HD-DEN-14830-2

more compiler fixes

- -0
- +1
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h

3:10 pm

Michael Garthwaite

More
34e3a45
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more HD-UCOMMITS-20

DEN-14830: compiler fixes for develop.

- -0
- +10
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h

3:04 pm

Michael Garthwaite

More
30bc07a
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more HD-DEN-14830-2

DEN-14830: Implemented temperature recovery to be set at +-2 C of target temp. Implemented dialysate temperature alarms to have a clear period of 30s.