hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Mar 2023
11:35 am

wbracken  (deleted user)

Change cmd to prompt

Change cmd to prompt

11:08 am

Michael Garthwaite

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

Wednesday 08 Mar 2023
9:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 pm

Sean Nash

Remove blank line.

Remove blank line.

7:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:08 pm

Sean Nash

FALSE was right.

FALSE was right.

7:03 pm

Sean Nash

Add space after "(".

Add space after "(".

7:01 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

7:00 pm

Sean Nash

Add blank line before comment.

Add blank line before comment.

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:32 pm

Sean Nash

10:58 am

wbracken  (deleted user) and Michael Garthwaite

9:48 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:47 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:47 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:47 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:47 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:46 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:42 am

Michael Garthwaite

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

9:41 am

Sean Nash

Fixed.

Fixed.

9:41 am

Sean Nash

Variable is also updated by receipts of DG flow broadcasts. I believe it is overridable on DG side.

Variable is also updated by receipts of DG flow broadcasts. I believe it is overridable on DG side.

9:38 am

Sean Nash

Concern was originally just for retract due to highest speed. We ended up reducing retract speed to reduce likelihood of stalls. Still a good idea to check for it though and since retract, preload ...

Concern was originally just for retract due to highest speed. We ended up reducing retract speed to reduce likelihood of stalls. Still a good idea to check for it though and since retract, preload and seek all share same relatively high speed, these are the ops that have the check. For bolus and continuous, should not stall at these speeds and would catch with rate alarm if it did.

9:33 am

Sean Nash

Fixed.

Fixed.

9:32 am

Sean Nash

Fixed.

Fixed.

9:30 am

Sean Nash

Fixed.

Fixed.