Activity hdfirmware/

3:51 pm

wbracken (deleted user)

More
HD-DEN-14918-1
finished reviewing

3:41 pm

Dara Navaei

More
HD-DEN-14918-1
started review

HD-DEN-14918_Pba Pbo And OB Not Available ON Debug Screen

1:20 pm

wbracken (deleted user)

More
Re: HD-DEN-14689-1
commented on review

Isn't deleted statement correct?

1:19 pm

wbracken (deleted user)

More
Re: HD-DEN-14689-1
commented on review

Isn't deleted statement correct?

1:18 pm

wbracken (deleted user)

More
Re: HD-DEN-14689-1
commented on review

Isn't deleted statement correct?

1:17 pm

wbracken (deleted user)

More
Re: HD-DEN-14689-1
commented on review

Isn't delete statement correct?

10:19 am

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACK...

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACKing (TRUE) or NAKing (FALSE) this command). Here, we are NAKing the command, so FALSE was appropriate.

10:16 am

Sean Nash

Has DG check-in msg ID been made available for re-purpose? RESOLVED in CODE WALKTHROUGH.

Has DG check-in msg ID been made available for re-purpose?
RESOLVED in CODE WALKTHROUGH.

10:14 am

Michael Garthwaite

More
Re: HD-DEN-14689-1
replied to Sean Nash

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

10:01 am

Dara Navaei

More
HD-DEN-14888-1
started review

HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment

9:48 am

Sean Nash

More
Re: HD-DEN-14689-1
commented on review

Why removed?

11:35 am

wbracken (deleted user)

More
Re: HD-DEN-14689-1
commented on review

Change cmd to prompt

11:08 am

Michael Garthwaite

More
Re: HD-DEN-14689-1
replied to Sean Nash

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()

1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );

2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );