hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Mar 2023
10:20 am

Michael Garthwaite

Merge branch 'staging' into DEN-14830-incorrect-dialysate-temperature-alarm-triggered

Options
10:03 am

Sean Nash

Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to z...

Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to zero before you get to this state.

10:02 am

Sean Nash

Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c an...

Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c and perhaps elsewhere to implement that change.
Also, in Reservoirs.c, we will want to prevent dialysate use from being counted while in re-prime states.
Also, there were some alarms we wanted to exempt while performing re-prime.
Let me know if you'd like me to handle any of these parts of the implementation.

10:01 am

Steve Jarpe

Done.

Done.

10:01 am

Steve Jarpe

This was removed when the function was changed to solve other problems.

This was removed when the function was changed to solve other problems.

10:01 am

Sean Nash

Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names).

Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names).

10:00 am

Steve Jarpe

Removed

Removed

9:59 am

Steve Jarpe

Created an init function that initializes variables and sets the pump flow rates to 0.

Created an init function that initializes variables and sets the pump flow rates to 0.

9:58 am

Steve Jarpe

This was done with a flag instead.

This was done with a flag instead.

9:58 am

Steve Jarpe

Done

Done

9:57 am

Steve Jarpe

Removed and replaced with a different approach (flag)

Removed and replaced with a different approach (flag)

9:56 am

Steve Jarpe

Done

Done

9:32 am

Steve Jarpe

I am unfamiliar with all of those parts of the firmware, so it would probably be more efficient for you to do them.

I am unfamiliar with all of those parts of the firmware, so it would probably be more efficient for you to do them.

9:11 am

Steve Jarpe

Done

Done

8:56 am

Sean Nash

Need to reject a saline bolus request if re-prime is in progress.

Need to reject a saline bolus request if re-prime is in progress.

8:34 am

Sean Nash

DEN-14888: Reduced time to treatment end escalation from 15 to 10 minutes per latest spec.

Options
    • -1
    • +1
    /firmware/App/Modes/TreatmentEnd.c
Tuesday 14 Mar 2023
5:41 pm

Sean Nash

If we get interrupted by an alarm, how will these vars get reset?

If we get interrupted by an alarm, how will these vars get reset?

5:36 pm

Sean Nash

I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state.

I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state.

5:34 pm

Sean Nash

I suppose that could work.

I suppose that could work.

5:28 pm

Sean Nash

Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and th...

Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and then start both DPi and DPo at fast purge rate together.

5:28 pm

Steve Jarpe

The timer should have been 5 minutes, my mistake. The purpose is to prevent repeated triggering of the reprime after the 5 minute before treatment reprime is done, as you pointed out. If I change t...

The timer should have been 5 minutes, my mistake. The purpose is to prevent repeated triggering of the reprime after the 5 minute before treatment reprime is done, as you pointed out. If I change the 5 hours to 5 minutes, is that OK?

5:06 pm

Sean Nash

Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state.

Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state.

5:02 pm

Sean Nash

Timer counter is reset in both cases so should be done once before or after the in progress condition is checked.

Timer counter is reset in both cases so should be done once before or after the in progress condition is checked.

5:00 pm

Sean Nash

Need to command dialysate pumps to zero flow rate so they start ramping down.

Need to command dialysate pumps to zero flow rate so they start ramping down.

4:55 pm

Sean Nash

This check to see if it's time to do reprime should be moved to the handler for dialysis: ultrafiltration state (function just below this one) - because we would not want to start a reprime in the ...

This check to see if it's time to do reprime should be moved to the handler for dialysis: ultrafiltration state (function just below this one) - because we would not want to start a reprime in the middle of a saline bolus or a reprime and because we should only be incrementing the timer counter during actual treatment (when treatment time is not paused).

4:43 pm

Sean Nash

I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway. I th...

I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway.
I think we just do reprime if 30 min interval OR 5 minutes remaining in treatment. And once we do the reprime for 5 min before end of treatment, we need some way to not do it again (i.e. if we just say time remaining <= 5 minutes, we will keep doing reprimes over and over again for the last 5 minutes).

4:39 pm

Sean Nash

Comment doesn't match const name. This is essentially 5 hours. Why are we repriming after 5 hours? We have a #define below that seems to be better suited for the reprime 5 minutes before end of tre...

Comment doesn't match const name.
This is essentially 5 hours. Why are we repriming after 5 hours?
We have a #define below that seems to be better suited for the reprime 5 minutes before end of treatment. So why do we need this const?

4:27 pm

Sean Nash

Do we need something similar to this for dialyzer reprime?

Do we need something similar to this for dialyzer reprime?

4:26 pm

Sean Nash

Maybe state durations instead of function delays.

Maybe state durations instead of function delays.

4:03 pm

Sean Nash

I think the rest of these are durations, not intervals.

I think the rest of these are durations, not intervals.