Activity hdfirmware/

4:11 pm

Sean Nash

More
bed5628
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: updates to pressure POST test and 24V range alarms.

- -1
- +1
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -11
- +25
/firmware/App/Controllers/Voltages.c
- History
- Source
- Diff
/firmware/App/Controllers/Voltages.c

2:22 pm

Sean Nash

More
HD-DEN-14860-1
finished reviewing

12:23 pm

Michael Garthwaite

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

11:33 am

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

11:28 am

Dara Navaei

More
e87ab5a
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:26 am

Darren Cox <darren_m@cox.net>

More
bd824a6
changed 1 file
develop

Merge DEN-14860 branch

- -10
- +10
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

10:18 am

Michael Garthwaite

More
Re: HD-DEN-14999-2
commented on review

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

9:47 am

wbracken (deleted user)

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

9:44 am

wbracken (deleted user)

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

9:41 am

Sean Nash

More
13b15c2
changed 3 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

- -8
- +1
/firmware/App/Modes/Rinseback.c
- History
- Source
- Diff
/firmware/App/Modes/Rinseback.c
- -31
- +2
/firmware/App/Modes/TreatmentRecirc.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentRecirc.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

9:40 am

Sean Nash

More
Re: HD-DEN-14999-2
replied to wbracken (deleted user)

Warning (13 min) removed since no longer alarming at 15 min.

9:38 am

Sean Nash

More
Re: HD-DEN-14999-2
replied to wbracken (deleted user)

Fixed.

11:09 pm

Sean Nash

More
be2b776
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: on blood leak detection, alarm, but then go to init state to prevent re-trigger after alarm cleared.

- -0
- +1
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c

4:30 pm

wbracken (deleted user)

More
Re: HD-DEN-14860-1
replied to dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:11 pm

James Walter Taylor <jtaylor@diality.com>

More
b4bb0e5
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more HD-DEN-15016-1

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased message ACK timeouts, for both DG and UI.

- -3
- +3
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

4:01 pm

Dara Navaei

More
HD-DEN-15016-1
started review

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

2:29 pm

dcox (deleted user)

More
Re: HD-DEN-14860-1
replied to wbracken (deleted user)

Updated all headers.

2:27 pm

Darren Cox <darren_m@cox.net>

More
0cf731b
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14860-1

DEN-14860 Updated headers per code review comment.

- -10
- +10
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

12:23 pm

wbracken (deleted user)

More
Re: HD-DEN-14999-2
commented on review

Add timeOfLastUICheckin and uiDidCommunicate.

11:35 am

Dara Navaei

More
8d24827
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:22 am

Sean Nash

More
37ac88d
changed 1 file
develop

Merge branch 'DEN-14999-alarm-table-updates' into develop

- -10
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

11:20 am

Sean Nash

More
0471700
changed 4 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: Removed minimum UF change. Added 250ms of persistence to HD fluid leak alarm. Increased no ack retries from 8 to 10 because UI needed more time at startup. Accept UI check-in message regardless of payload size because UI is sending 2 different flavors of check-in message.

- -1
- +11
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -1
- +1
/firmware/App/Modes/ModeTreatmentParams.h
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatmentParams.h
- -1
- +2
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -10
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

2:23 pm

wbracken (deleted user)

More
Re: HD-DEN-14999-2
commented on review

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

1:33 pm

Sean Nash

More
4408a78
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: Do not alarm after rinseback completed due to 15 min t/o.

- -13
- +4
/firmware/App/Modes/Rinseback.c
- History
- Source
- Diff
/firmware/App/Modes/Rinseback.c

1:29 pm

Dara Navaei

More
293e020
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

1:29 pm

Darren Cox <darren_m@cox.net>

More
260d817
changed 0 files
develop

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

1:22 pm

Darren Cox <darren_m@cox.net>

More
3190022
changed 3 files
develop

Merge DEN-14860

- -0
- +14
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -47
- +86
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -1
- +1
/firmware/App/Services/Reservoirs.h
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.h

1:14 pm

Sean Nash

More
0665a32
changed 5 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

Fixed merge conflict from staging.

- -2
- +2
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c
- -2
- +2
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -14
- +7
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -12
- +77
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -26
- +64
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

1:02 pm

Sean Nash

More
b757b48
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more HD-DEN-14999-2

DEN-14999: Removed alarm 306. Increased t/o on alarm 318 to 10 sec. Change alarm 141 to not clear immediate, but instead clear when low level sees fluid.

- -1
- +1
/firmware/App/Controllers/AirPump.c
- History
- Source
- Diff
/firmware/App/Controllers/AirPump.c
- -27
- +7
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c

11:38 am

Dara Navaei

More
f27b4ef
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

hdfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Sean Nash

Sean Nash

Michael Garthwaite

Sean Nash

Dara Navaei

Darren Cox <darren_m@cox.net>

Michael Garthwaite

wbracken (deleted user)

wbracken (deleted user)

Sean Nash

Sean Nash

Sean Nash

Sean Nash

wbracken (deleted user)

James Walter Taylor <jtaylor@diality.com>

Dara Navaei

dcox (deleted user)

Darren Cox <darren_m@cox.net>

wbracken (deleted user)

Dara Navaei

Sean Nash

Sean Nash

wbracken (deleted user)

Sean Nash

Dara Navaei

Darren Cox <darren_m@cox.net>

Darren Cox <darren_m@cox.net>

Sean Nash

Sean Nash

Dara Navaei