hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

I saw the corresponding alarm 44, on the initial power-up. However, going back to the UI log file shows UI communication within 1 second of triggering the error. So either the received message was ...

I saw the corresponding alarm 44, on the initial power-up. However, going back to the UI log file shows UI communication within 1 second of triggering the error. So either the received message was that much delayed, or the check is otherwise broken.

Done.

Done.

Done.

Done.

DEN-14999: Small fix to HD WD POST.

DEN-14999: Removed BP and DPi flow range checks.

    • -30
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -17
    • +3
    /firmware/App/Controllers/DialInFlow.c
DEN-14999: Removed redundant trigger for DG restarted alarm.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14999-alarm-table-updates' into develop

DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start command

My branch (and your DG branch) changed this to 10.

My branch (and your DG branch) changed this to 10.

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

Change back to 200.

Change back to 200.

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

DEN-14999: Fixed sending of DG valve settings command.

Merge branch 'staging' into DEN-14830-incorrect-dialysate-temperature-alarm-triggered

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

DEN-14999, DEN-15030 updated the DG start command payload

DEN-14999: updates to pressure POST test and 24V range alarms.

    • -11
    • +25
    /firmware/App/Controllers/Voltages.c
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge DEN-14860 branch

    • -10
    • +10
    /firmware/App/Services/Reservoirs.c
What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

    • -31
    • +2
    /firmware/App/Modes/TreatmentRecirc.c
Warning (13 min) removed since no longer alarming at 15 min.

Warning (13 min) removed since no longer alarming at 15 min.