hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-15049-fw-hd-voltage-not-trigger-alarm-76-when-voltage-out-of-range-in-line' into staging

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-15049-fw-hd-voltage-not-trigger-alarm-76-when-voltage-out-of-range-in-line' into develop

# Conflicts:

# firmware/App/HDCommon.h

They should remain. Will be uncommented when all DVT units have updated hardware.

They should remain. Will be uncommented when all DVT units have updated hardware.

Are these alarms intentionally commented? Should they be activated or removed?

Are these alarms intentionally commented? Should they be activated or removed?

Update header, setUFVolStatus

Update header, setUFVolStatus

Update header

Update header

Update header.

Update header.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15105: Started adding pre-tx patient connection sub-states.

Corrected

Corrected

Corrected

Corrected

Fixed.

Fixed.

Corrected

Corrected

Corrected

Corrected

Fixed.

Fixed.

Removed

Removed

DEN-15049 Code review changes to accomodate using CPLD for power loss detection

    • -14
    • +3
    /firmware/App/Controllers/Voltages.c
Merge branch 'staging' into DEN-15049-fw-hd-voltage-not-trigger-alarm-76-when-voltage-out-of-range-in-line

I think we can just say "if ( TRUE == hasPowerBeenLost )" here. Zero trigger persistence time now that CPLD is making determination.

I think we can just say "if ( TRUE == hasPowerBeenLost )" here. Zero trigger persistence time now that CPLD is making determination.

I think we can fit this whole comment on the 1 line. Bring closer to break; if need more room.

I think we can fit this whole comment on the 1 line. Bring closer to break; if need more room.

No longer needed?

No longer needed?