Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 24 Apr 2023

3:21 pm

James Walter Taylor <jtaylor@diality.com>

More
be587ee
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more HD-DEN-14980-1

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Addressed code review comments.

- -10
- +10
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

3:20 pm

jtaylor (deleted user)

More
Re: HD-DEN-14980-1
replied to Sean Nash

Done.

Done.

1:55 pm

Sean Nash

More
Re: HD-DEN-14980-1
replied to jtaylor (deleted user)

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

1:36 pm

Dara Navaei

More
13106f2
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

1:33 pm

Sean Nash

More
8c10d39
changed 0 files
develop

Merge branch 'DEN-15183-2-in-treatment-rinseback-workflow-changes' into develop

1:33 pm

Sean Nash

More
93334d5
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more HD-DEN-15183-2

DEN-15183-2: Fix init of tx recirc to correct state.

- -1
- +1
/firmware/App/Modes/TreatmentRecirc.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentRecirc.c

12:25 pm

jtaylor (deleted user)

More
Re: HD-DEN-14980-1
replied to Sean Nash

Thank you - corrected.

Thank you - corrected.

12:25 pm

James Walter Taylor <jtaylor@diality.com>

More
80fe66a
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more HD-DEN-14980-1

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Addressed paren typo from code review

- -4
- +4
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

12:14 pm

Dara Navaei

More
HD-DEN-15183-2
resumed reviewing

12:13 pm

Sean Nash

More
10c0ce3
changed 3 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more HD-DEN-15183-2

DEN-15183-2: Estimate initial DPo rate correction offset based on data collected by Systems team to improve UF control at treatment start.

- -0
- +22
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -0
- +1
/firmware/App/Controllers/DialOutFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.h
- -0
- +1
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c

10:45 am

Dara Navaei

More
bbb7dd3
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

10:45 am

Dara Navaei

More
fd9d9df
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c

10:44 am

Michael Garthwaite

More
d10cae6
changed 0 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more

Merge branch 'DEN-15203-alarm-does-not-trigger-when-blood-pump-is-reversed' into staging

10:43 am

Michael Garthwaite

More
HD-DEN-15203-1
Closed

10:31 am

Sean Nash

More
Re: HD-DEN-14546-3
commented on review

Why accept Heparin resume when our syringe is empty?

Why accept Heparin resume when our syringe is empty?

10:23 am

Sean Nash

More
Re: HD-DEN-15196-1
commented on review

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (t...

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (timeout).

10:06 am

Sean Nash

More
HD-DEN-15203-1
finished reviewing

9:41 am

Sean Nash

More
Re: HD-DEN-14980-1
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

More
Re: HD-DEN-14980-1
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

More
Re: HD-DEN-14980-1
commented on review

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

8:35 am

Dana Rich <drich@sunriselabs.com>

More
fb73bb3
changed 1 file
DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise HD-DEN-16565-1

DEN-16565 cherry picked Sunrise commit IDs from 606b373bf27d70b0b8fde88d84d0a46e4c39b56d to dad52d69c15f96d2b7ca7e22138f5d07a3948a9f

- -4
- +4
/firmware/source/sys_link.cmd
- History
- Source
- Diff
/firmware/source/sys_link.cmd

8:35 am

Dana Rich <drich@sunriselabs.com>

More
ba5783f
changed 1 file
DEN-14892-add-bootloader-to-existing-dg-firmware

64bit alignment for flash

- -25
- +25
/firmware/source/sys_link.cmd
- History
- Source
- Diff
/firmware/source/sys_link.cmd

8:35 am

Dana Rich <drich@sunriselabs.com>

More
606b373
changed 1 file
DEN-14892-add-bootloader-to-existing-dg-firmware

64bit alignment for flash

- -25
- +25
/firmware/source/sys_link.cmd
- History
- Source
- Diff
/firmware/source/sys_link.cmd

8:35 am

Dana Rich <drich@sunriselabs.com>

More
1786a75
changed 1 file
DEN-14892-add-bootloader-to-existing-dg-firmware

64bit alignment for flash

- -25
- +25
/firmware/source/sys_link.cmd
- History
- Source
- Diff
/firmware/source/sys_link.cmd

8:13 am

Michael Garthwaite

More
6ff0130
changed 0 files
develop

Merge branch 'DEN-15203-alarm-does-not-trigger-when-blood-pump-is-reversed' into develop

8:13 am

Dara Navaei

More
32b84e7
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

Sunday 23 Apr 2023

10:48 pm

Dara Navaei

More
61e5c01
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

10:48 pm

Sean Nash

More
4d855ff
changed 2 files
develop

Merged DEN-15183-2 to develop.

- -2
- +2
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -1
- +1
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c

8:40 pm

Sean Nash

More
38ebc96
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 236 more HD-DEN-15183-2

DEN-15183-2: Minor fixes to Tx recirculation updates.

- -11
- +7
/firmware/App/Modes/TreatmentRecirc.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentRecirc.c

2:39 pm

Dana Rich <drich@sunriselabs.com>

More
f8e557b
changed 2 files
DEN-14892-add-bootloader-to-existing-dg-firmware HD-DEN-14892-3 BOOTLOADER-DEN-14892-2

Hal changes

- -1
- +1
/firmware/HD.dil
- History
- Source
- Diff
/firmware/HD.dil
- -94
- +94
/firmware/source/sys_startup.c
- History
- Source
- Diff
/firmware/source/sys_startup.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 16:36 -0700