hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15267-request-create-dialin-command-to-enable-air-bubble-alarm-in-service-mode-air-bubble' into develop

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Merged DEN-15267 to staging.

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

DEN-15267: Addressed code review comment.

Remove extra blank line.

Remove extra blank line.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Fixed merge conflict from DEN-15267.

DEN-15267: Refactored bubble detector driver to allow modes to push enable/disable instead of determining based on current op mode. Added support for new Dialin command to enable/disable venous bubble alarm detection.

    • -27
    • +20
    /firmware/App/Controllers/Bubble.c
HD-DEN-15267_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
HD-DEN-15267_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
DEN-15104 Update for FE and OE errors. Minor correction to bloodLeakEmbModeCmd array. Enable venous pressure alarm which was commented out.

    • -222
    • +226
    /firmware/App/Services/Interrupts.c
Merge branch 'staging' into DEN-15104-hd-fpga-communications

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Fixed merge conflicts from DEN-14262.

    • -11
    • +16
    /firmware/App/Controllers/SyringePump.c
Please see changes.

Please see changes.

Done

Done