hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15245: Addressed DEN-15245.

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15229_FW Dpi Pump ON During Inverted Dialyzer
HD-DEN-15229_FW Dpi Pump ON During Inverted Dialyzer
DEN-15229 Stop DPI when door is opened in patient connect.

    • -10
    • +28
    /firmware/App/Modes/ModePreTreat.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merged DEN-15199

This was updated but not pushed.

This was updated but not pushed.

DEN-15199 addressed the code review comment

This was a mistake. I fixed it.

This was a mistake. I fixed it.

DEN-15199 merged staging

DEN-15199 renamed the test configuration enums

    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15267-request-create-dialin-command-to-enable-air-bubble-alarm-in-service-mode-air-bubble' into develop

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Merged DEN-15267 to staging.

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE