hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DIAL-251: reworked events for operation status and operation state transitions

    • -1
    • +1
    /firmware/App/Modes/ConsumableSelfTest.c
    • -5
    • +2
    /firmware/App/Modes/ModeTreatmentParams.c
    • -4
    • +29
    /firmware/App/Modes/OperationModes.c
    • -0
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
  1. … 4 more files in changeset.
Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

Make U32.

Make U32.

Should we have an else to turn pump and heater back on when door is closed?

Should we have an else to turn pump and heater back on when door is closed?

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handl...

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handle it.

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

I think this whole function should be moved down into test support functions section.

I think this whole function should be moved down into test support functions section.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

case body should be indented.

case body should be indented.

Use new #define from comment above.

Use new #define from comment above.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

Use new #define (from comment above).

Use new #define (from comment above).

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

Update inputs

Update inputs

Comment for what we're doing here.

Comment for what we're doing here.

Put this prototype declaration last w/ blank line before.

Put this prototype declaration last w/ blank line before.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15196-Alarm-98-rework' into staging

Merge branch 'staging' into DEN-15196-Alarm-98-rework

Add comment

Add comment

DEN-15274 updated the test configuration reservoir management

    • -26
    • +14
    /firmware/App/Modes/ModePreTreat.c
DEN-15274 added code to support the test configurations

    • -13
    • +200
    /firmware/App/Modes/ModePreTreat.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Fixed merge conflict.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged DEN-15060 to staging.