hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Now it's gone. No longer needed?

Now it's gone. No longer needed?

Missing function header

Missing function header

Removed

Removed

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

Corrected

Corrected

Removed

Removed

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.

Removed.

Removed.

Cut and paste error from DG. Corrected.

Cut and paste error from DG. Corrected.

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

I don't see these two functions in the .c file. Are they not yet implemented?

I don't see these two functions in the .c file. Are they not yet implemented?

Why 2 of these?

Why 2 of these?

What does this do? Why 64 (not 32)?

What does this do? Why 64 (not 32)?

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.