hdfirmware

Clone Tools

Stats

Commits this week: 13
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 14 May 2023
12:40 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -152
    • +157
    /firmware/App/Modes/ModePreTreat.c
12:40 pm

Dara Navaei

Done

Done

12:40 pm

Dara Navaei

Done

Done

12:39 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

I changed the code.

I changed the code.

12:37 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

12:32 pm

Dara Navaei

Done

Done

12:28 pm

Dara Navaei

Done. This indentation was picked by Code Composer Studios though.

Done. This indentation was picked by Code Composer Studios though.

12:27 pm

Dara Navaei

Done

Done

11:48 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15104 Updates per code review.

Options
    • -4
    • +5
    /firmware/App/Services/FPGA.c
11:28 am

wbracken  (deleted user)

No longer needed.

No longer needed.

10:10 am

Dara Navaei

DEN-15274 added code to check the checkin message from dialin

Options
    • -1
    • +7
    /firmware/App/Services/SystemComm.c
    • -0
    • +13
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +2
    /firmware/App/Services/SystemCommMessages.h
Saturday 13 May 2023
1:09 pm

Michael Garthwaite

DIAL-251: fixed payload preparation for operation status event. Fixed compiler warnings

Options
    • -8
    • +13
    /firmware/App/Modes/OperationModes.c
    • -0
    • +18
    /firmware/App/Modes/OperationModes.h
Friday 12 May 2023
5:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:29 pm

Sean Nash

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

5:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:28 pm

Sean Nash

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

Now it's gone. No longer needed?

Now it's gone. No longer needed?

3:56 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
3:55 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into develop

Options
    • -13
    • +38
    /firmware/App/Modes/ModePreTreat.c