hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed merge conflict from DEN-15245.

    • -3
    • +4
    /firmware/App/Controllers/SyringePump.c
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see fix.

I don't see fix.

I don't see fix.

I don't see fix.

Should the argument for setCurrentSubState be a CONSUMABLE_SELF_TEST_STATE_T? Other calls don't cast to U32.

Should the argument for setCurrentSubState be a CONSUMABLE_SELF_TEST_STATE_T? Other calls don't cast to U32.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

DIAL-251: code review comments.

yes we should. fixed to have these calls in their respective transition functions.

yes we should. fixed to have these calls in their respective transition functions.

Fixed. Thanks!

Fixed. Thanks!

DIAL-251: fixed warnings. restored some old event broadcasting for compatibility. code review comments

    • -0
    • +2
    /firmware/App/Modes/ConsumableSelfTest.c
    • -3
    • +6
    /firmware/App/Modes/ModeTreatmentParams.c
    • -8
    • +22
    /firmware/App/Modes/OperationModes.c
    • -18
    • +0
    /firmware/App/Modes/OperationModes.h
Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!