hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 10 Dec 2020
11:24 am

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Refactor alarm management module

Options
    • -170
    • +27
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +3
    /firmware/App/Services/SystemComm.c
11:00 am

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Added time out for purge air state

Options
    • -3
    • +21
    /firmware/App/Modes/Prime.c
Wednesday 09 Dec 2020
1:30 pm

Sean Nash

DEN-5674: Fixed valves POST call. Added alarm for FPGA comm timeout.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
10:31 am

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Added handler for prime sub-mode states

Options
    • -4
    • +182
    /firmware/App/Modes/Prime.c
10:27 am

Sean Nash

DEN-5674: Removed alarm dialyzer bypass flag. Added alarm user option for alarms that simply require acknowledgement. Added some alarm action handling for treatment mode.

Options
    • -2
    • +1
    /firmware/App/Modes/ModeFault.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeService.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +62
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.c
    • -82
    • +126
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +3
    /firmware/App/Services/AlarmMgmt.h
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
Tuesday 08 Dec 2020
10:08 am

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Created skeleton for pre-treatment mode

Options
    • -24
    • +104
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +54
    /firmware/App/Modes/Prime.c
    • -0
    • +44
    /firmware/App/Modes/Prime.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
9:43 am

Sean Nash

DEN-5674: Added mode specific masking of enabled user alarm recovery actions.

Options
    • -1
    • +5
    /firmware/App/Modes/ModeFault.c
    • -0
    • +4
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +5
    /firmware/App/Modes/ModePostTreat.c
    • -0
    • +5
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +5
    /firmware/App/Modes/ModeService.c
    • -0
    • +5
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +6
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +5
    /firmware/App/Modes/ModeTreatmentParams.c
    • -7
    • +41
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +4
    /firmware/App/Services/AlarmMgmt.h
9:02 am

Sean Nash

DEN-5674: Fixed drain reservoir cmd to DG to include indication of whether reservoir load cells should be tared.

Options
    • -6
    • +55
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +12
    /firmware/App/Controllers/DGInterface.h
    • -1
    • +1
    /firmware/App/Modes/ModeTreatment.h
    • -4
    • +6
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
Monday 07 Dec 2020
5:31 pm

Sean Nash

DEN-5674: Added alarm (empty) action signal handling functions to the various op modes.

Options
    • -0
    • +14
    /firmware/App/Modes/ModeFault.c
    • -3
    • +4
    /firmware/App/Modes/ModeFault.h
    • -0
    • +14
    /firmware/App/Modes/ModeInitPOST.c
    • -5
    • +6
    /firmware/App/Modes/ModeInitPOST.h
    • -1
    • +15
    /firmware/App/Modes/ModePostTreat.c
    • -3
    • +4
    /firmware/App/Modes/ModePostTreat.h
    • -1
    • +15
    /firmware/App/Modes/ModePreTreat.c
    • -4
    • +5
    /firmware/App/Modes/ModePreTreat.h
    • -0
    • +14
    /firmware/App/Modes/ModeService.c
    • -3
    • +4
    /firmware/App/Modes/ModeService.h
    • -0
    • +14
    /firmware/App/Modes/ModeStandby.c
    • -4
    • +5
    /firmware/App/Modes/ModeStandby.h
    • -0
    • +14
    /firmware/App/Modes/ModeTreatment.c
    • -6
    • +7
    /firmware/App/Modes/ModeTreatment.h
    • -1
    • +15
    /firmware/App/Modes/ModeTreatmentParams.c
  16. … 5 more files in changeset.
Friday 04 Dec 2020
3:16 pm

Sean Nash

DEN-5674: Added alarm sub-rank property and use for determining top priority alarm for UI.

Options
    • -0
    • +1
    /firmware/App/HDCommon.h
    • -21
    • +61
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +7
    /firmware/App/Services/FPGA.c
10:59 am

Sean Nash

DEN-5674: Added synchronize of alarm audio/lamp control with published alarm state so that UI can flash alarm in sync w/ lamp. Added alarm audio.

Options
    • -3
    • +4
    /firmware/App/Controllers/AlarmLamp.c
    • -117
    • +74
    /firmware/App/Services/AlarmMgmt.c
    • -6
    • +10
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +26
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -32
    • +0
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
    • -3
    • +0
    /firmware/App/Tasks/TaskGeneral.c
Thursday 03 Dec 2020
4:03 pm

Sean Nash

DEN-5674: Updated alarm messaging. Added concept of alarm condition detected and ability to clear this. Clear all recoverable alarms when user chooses an action.

Options
    • -172
    • +120
    /firmware/App/Services/AlarmMgmt.c
    • -2
    • +5
    /firmware/App/Services/AlarmMgmt.h
    • -1
    • +5
    /firmware/App/Services/SystemComm.c
    • -21
    • +77
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +6
    /firmware/App/Services/SystemCommMessages.h
10:57 am

Sean Nash

DEN-5887: Fixed name format for const data to all caps w/ underlines per coding standard.

Options
    • -5
    • +5
    /firmware/App/Controllers/AlarmLamp.c
    • -14
    • +14
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/HDCommon.h
    • -12
    • +12
    /firmware/App/Modes/ModeTreatmentParams.c
    • -3
    • +3
    /firmware/App/Services/AlarmMgmt.c
Wednesday 02 Dec 2020
3:17 pm

Sean Nash

DEN-5887: Added controller type property to PI controller as was added in DG stack. Added max I step size to prevent lasting effects of a large but brief disturbance in control input.

Options
    • -158
    • +25
    /firmware/App/Services/AlarmMgmt.c
    • -24
    • +61
    /firmware/App/Services/PIControllers.c
11:55 am

Sean Nash

DEN-5887: Moved some load cell functions from dialysate outlet pump controller to DG Interface module. Added small and large moving average filters to load cell readings. Use small moving average for normal UF tracking/control and use large moving average for baseline and final reservoir weights to minimize reservoir transition errors due to load cell noise.

Options
    • -34
    • +286
    /firmware/App/Controllers/DGInterface.c
    • -12
    • +33
    /firmware/App/Controllers/DGInterface.h
    • -115
    • +0
    /firmware/App/Controllers/DialOutFlow.c
    • -15
    • +0
    /firmware/App/Controllers/DialOutFlow.h
    • -41
    • +5
    /firmware/App/Modes/Dialysis.c
    • -7
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +6
    /firmware/App/Tasks/TaskGeneral.c
10:26 am

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Removed test support macros

Options
    • -1
    • +1
    /firmware/App/Controllers/AlarmLamp.c
    • -1
    • +1
    /firmware/App/Controllers/AlarmLamp.h
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/Buttons.c
    • -2
    • +2
    /firmware/App/Controllers/Buttons.h
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Controllers/Valves.c
    • -8
    • +5
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/WatchdogMgmt.c
Tuesday 01 Dec 2020
3:06 pm

Sean Nash

DEN-4641: Addressed code review feedback.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeTreatment.c
2:49 pm

Sean Nash

DEN-4641: re-ran local test script.

Options
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -442
    • +388
    /results/VectorCAST.log
2:29 pm

Sean Nash

DEN-4641: Updated persistent alarms to use ms instead of task interval counts.

Options
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -4
    • +3
    /results/Build_Status_Report.csv
    • -398
    • +398
    /results/VectorCAST.log
    • -2
    • +2
    /results/cppcheckError.csv
2:09 pm

Sean Nash

DEN-4641: Addressed code review feedback.

Options
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.h
    • -4
    • +4
    /firmware/App/Controllers/DialInFlow.c
    • -10
    • +12
    /firmware/App/Controllers/DialOutFlow.c
    • -25
    • +25
    /firmware/App/Modes/ModeTreatmentParams.h
    • -5
    • +4
    /firmware/App/Modes/OperationModes.c
    • -6
    • +2
    /firmware/App/Services/SystemCommMessages.c
12:40 pm

Sean Nash

DEN-4641: Merged with master. Fixed merge conflicts. Addressed code review feedback.

Options
    • -215
    • +340
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +24
    /firmware/App/Controllers/BloodFlow.h
    • -3
    • +7
    /firmware/App/Controllers/DGInterface.h
    • -207
    • +309
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +19
    /firmware/App/Controllers/DialInFlow.h
    • -163
    • +152
    /firmware/App/Controllers/DialOutFlow.c
    • -7
    • +8
    /firmware/App/Controllers/DialOutFlow.h
    • -3
    • +3
    /firmware/App/Controllers/PresOccl.c
    • -9
    • +9
    /firmware/App/Controllers/PresOccl.h
    • -5
    • +10
    /firmware/App/HDCommon.h
    • -20
    • +22
    /firmware/App/Modes/ModeInitPOST.c
    • -70
    • +63
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +1
    /firmware/App/Modes/ModeTreatment.h
    • -71
    • +84
    /firmware/App/Modes/ModeTreatmentParams.c
    • -3
    • +4
    /firmware/App/Modes/ModeTreatmentParams.h
  16. … 11 more files in changeset.
8:46 am

Sean Nash

DEN-4641: Added new alarm IDs to alarm table.

Options
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.c
8:34 am

Sean Nash

DEN-4641: re-ran local test script.

Options
    • -8
    • +6
    /results/Build_Status_Report.csv
Monday 30 Nov 2020
10:21 pm

Sean Nash

DEN-4641: Updates to UT/IT after code review fixes.

Options
    • -1
    • +152
    /results/Build_Status_Report.csv
9:54 pm

Sean Nash

DEN-4641: Addressed code review feedback.

Options
    • -35
    • +15
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +0
    /firmware/App/Controllers/BloodFlow.h
    • -29
    • +22
    /firmware/App/Controllers/DialInFlow.c
    • -6
    • +6
    /firmware/App/Controllers/DialInFlow.h
    • -37
    • +5
    /firmware/App/Controllers/PresOccl.c
    • -151
    • +1
    /results/Build_Status_Report.csv
    • -34777
    • +0
    /results/VectorCAST.log
    • -172
    • +0
    /results/cppcheck.log
    • -74
    • +0
    /results/cppcheckError.csv
9:21 pm

Sean Nash

DEN-4641: Re-ran local test script. Updates to UT.

Options
    • -6
    • +4
    /results/Build_Status_Report.csv
    • -438
    • +606
    /results/VectorCAST.log
8:45 pm

Sean Nash

DEN-4641: Ran local test script. Updates to IT.

Options
    • -7
    • +10
    /results/Build_Status_Report.csv
    • -2331
    • +2803
    /results/VectorCAST.log
    • -38
    • +35
    /results/cppcheckError.csv
10:00 am

Sean Nash

DEN-4641: Updates to IT.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
Wednesday 25 Nov 2020
2:32 pm

Sean Nash

DEN-4641: Updates to UT.

Options
    • -0
    • +2
    /firmware/App/Services/AlarmMgmt.h
11:18 am

Sean Nash

DEN-4641: Updates to UT.

Options
    • -13
    • +14
    /firmware/App/Controllers/PresOccl.c
    • -5
    • +6
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h