Activity hdfirmware/firmware/App/Controllers/DGInterface.c

3:43 pm

Darren Cox

More
HD-DEN-14830-2
resumed reviewing

9:04 am

jtaylor (deleted user)

More
HD-DEN-14999-2
finished reviewing

2:02 pm

Dara Navaei

More
HD-DEN-14999-3
started review

HD-DEN-14999_Alarm Table Updates Part 2

3:53 pm

Dara Navaei

More
HD-DEN-14999-2
finished reviewing

3:19 pm

Michael Garthwaite

More
HD-DEN-14999-2
resumed reviewing

12:23 pm

Michael Garthwaite

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

11:33 am

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

10:18 am

Michael Garthwaite

More
Re: HD-DEN-14999-2
commented on review

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

9:47 am

wbracken (deleted user)

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

9:44 am

wbracken (deleted user)

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

9:40 am

Sean Nash

More
Re: HD-DEN-14999-2
replied to wbracken (deleted user)

Warning (13 min) removed since no longer alarming at 15 min.

9:38 am

Sean Nash

More
Re: HD-DEN-14999-2
replied to wbracken (deleted user)

Fixed.

12:23 pm

wbracken (deleted user)

More
Re: HD-DEN-14999-2
commented on review

Add timeOfLastUICheckin and uiDidCommunicate.

2:23 pm

wbracken (deleted user)

More
Re: HD-DEN-14999-2
commented on review

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

11:07 am

wbracken (deleted user)

More
Re: HD-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

8:58 am

Sean Nash

More
Re: HD-DEN-14999-2
replied to wbracken (deleted user)

Changing from U32 to S32. It is a relative ms timer (so wouldn't be negative), but I needed to initialize this to something less than zero so that alarm ranking logic will be forced to rank a brand...

Changing from U32 to S32. It is a relative ms timer (so wouldn't be negative), but I needed to initialize this to something less than zero so that alarm ranking logic will be forced to rank a brand new alarm (triggered 0 ms ago).

10:28 pm