hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 22 Dec 2022
10:56 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:55 am

Michael Garthwaite

Fixed?

Fixed?

10:55 am

Michael Garthwaite

Fixed?

Fixed?

10:54 am

Michael Garthwaite

Fixed?

Fixed?

10:54 am

Michael Garthwaite

Fixed?

Fixed?

10:53 am

Michael Garthwaite

Fixed? There is a blank line here

Fixed? There is a blank line here

10:51 am

Michael Garthwaite

Used in airtrap.c and presoccl.c

Used in airtrap.c and presoccl.c

10:46 am

Michael Garthwaite

Unsure what table you are specifying. Does the current commit look correct?

Unsure what table you are specifying. Does the current commit look correct?

10:38 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:34 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:34 am

Michael Garthwaite

added the function call within the end of consumable self tests when air pump is enabled.

added the function call within the end of consumable self tests when air pump is enabled.

10:32 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:32 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:32 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:18 am

Sean Nash

Add // 150.

Add // 150.

Wednesday 21 Dec 2022
5:39 pm

Sean Nash

Can't have gaps in alarm enum/tables - will not compile. Need to pull in alarms from other branches if necessary to fill the gaps.

Can't have gaps in alarm enum/tables - will not compile. Need to pull in alarms from other branches if necessary to fill the gaps.

5:20 pm

Sean Nash

Set this to something between 0 and 19 (for staggering different broadcasts over typical 1 second interval). Use it to initialize data publication timer counter (which is currently not initialized ...

Set this to something between 0 and 19 (for staggering different broadcasts over typical 1 second interval).
Use it to initialize data publication timer counter (which is currently not initialized at all).

5:10 pm

Sean Nash

Remove blank line.

Remove blank line.

5:08 pm

Sean Nash

Keep blank line between functions.

Keep blank line between functions.

5:07 pm

Sean Nash

Need function header.

Need function header.

5:07 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:59 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Monday 19 Dec 2022
6:08 pm

Sean Nash

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

6:01 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

6:00 pm

Sean Nash

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

5:58 pm

Sean Nash

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

5:57 pm

Sean Nash

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while...

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.