hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Jan 2023
11:27 am

Michael Garthwaite

DEN-14011: created handleDrySelfTestStartState. code review comments.

Options
    • -1
    • +1
    ./PresOccl.c
  2. … 1 more file in changeset.
9:13 am

Sean Nash

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

9:11 am

Sean Nash

Should this 10 seconds only start once latch is locked?

Should this 10 seconds only start once latch is locked?

9:07 am

Sean Nash

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Thursday 19 Jan 2023
3:16 pm

Dara Navaei

HD-DEN-14011_Occulsion Alarm When Reseating
HD-DEN-14011_Occulsion Alarm When Reseating
2:01 pm

Michael Garthwaite

DEN-14011: added condition to check if BP is running while we do occlusion checks.

Options
    • -3
    • +5
    ./PresOccl.c
9:10 am

Sean Nash

DEN-14549: Rolled back change to include blood prime for normal inline pressure range checks. Leave as fixed max only range check in blood prime.

Options
    • -4
    • +2
    ./PresOccl.c
Wednesday 18 Jan 2023
12:38 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:58 am

Sean Nash

DEN-14549: include venous check in including blood prime.

Options
    • -2
    • +5
    ./PresOccl.c
11:55 am

Darren Cox

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

11:53 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:50 am

Sean Nash

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

11:48 am

Sean Nash

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

11:15 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:13 am

Darren Cox

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

11:08 am

Darren Cox

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Tuesday 17 Jan 2023
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:04 pm

Sean Nash

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

Darren Cox

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

11:35 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:19 am

Sean Nash

DEN-14549: maintain blood flow rate when alarm w/ blood recirc property pauses treatment. maintain Heparin dispense when blood recirc is occurring during alarm pause of treatment. include blood prime state in checks for inline pressure range.

Options
    • -24
    • +4
    ./PresOccl.c
  2. … 3 more files in changeset.
9:57 am

wbracken  (deleted user)

Add pressureSelfTestNormalizedStartTime to header.

Add pressureSelfTestNormalizedStartTime to header.

9:55 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:54 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:30 am

Sean Nash

DEN-14549: Misc updates to dry self-tests in pre-treatment.

Options
    • -3
    • +3
    ./PresOccl.c
  2. … 3 more files in changeset.