hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 12 Apr 2021
7:33 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed code review comments

Options
    • -105
    • +114
    ./BloodLeak.c
    • -16
    • +2
    ./BloodLeak.h
  3. … 6 more files in changeset.
5:07 pm

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./SyringePump.c
  2. … 2 more files in changeset.
10:57 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:49 am

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed init state of state machine for Blood Leak Detector

Options
    • -1
    • +1
    ./BloodLeak.c
10:24 am

Sean Nash

I don't think we should have state as overrideable. Here, you are only looking at non-override version of state, so override would not have any impact anyway. You could have Dialin function force a...

I don't think we should have state as overrideable. Here, you are only looking at non-override version of state, so override would not have any impact anyway.
You could have Dialin function force a transition to a given state - I think that would be useful from testing perspective. But transition would need to be more than just setting state - e.g. we would need to put sensor in zero state via FPGA if we wanted to go to the zero state in your state machine.

10:18 am

Sean Nash

But do we want to jump right into zero state or wait for pre-treatment to ask for it? Does zero require fluid (dialysate) to be in the line?

But do we want to jump right into zero state or wait for pre-treatment to ask for it? Does zero require fluid (dialysate) to be in the line?

10:12 am

pmontazemi  (deleted user)

Yes, Sean and I thought that it would be good for the SWVV, SYSVV, MFR, and SVC Teams to know via Dialin API which state the Blood Leak state machine is in. This detector comes with an independent ...

Yes, Sean and I thought that it would be good for the SWVV, SYSVV, MFR, and SVC Teams to know via Dialin API which state the Blood Leak state machine is in. This detector comes with an independent MCU thqat can be programmed and calibrated via UART and via HD FPGA including self-test mode and zeroing mode to zero the sensor when clear dialysate is run through it. Then a threshold of blood can be set to be detected as soon as blood gets across the dialyzer from the blood circuit to the dialysate circuit.

10:08 am

pmontazemi  (deleted user)

Good catch, addressed.

Good catch, addressed.

10:08 am

pmontazemi  (deleted user)

Good catch, addressed.

Good catch, addressed.

10:08 am

pmontazemi  (deleted user)

Good catch, addressed.

Good catch, addressed.

10:04 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:04 am

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed execBloodLeak header clarification needed

Options
    • -1
    • +1
    ./BloodLeak.c
10:03 am

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Corrected state machine BLOOD_LEAK_INIT_STATE case

Options
    • -1
    • +1
    ./BloodLeak.c
10:02 am

pmontazemi  (deleted user)

Addressed.

Addressed.

Sunday 11 Apr 2021
8:57 pm

Dara Navaei

Maybe I do not quite understand the architecture, but is there any reason that your are returning the state of the blood leak detector state machine?

Maybe I do not quite understand the architecture, but is there any reason that your are returning the state of the blood leak detector state machine?

8:54 pm

Dara Navaei

I suppose this is not the monitor function and it is the exec function?

I suppose this is not the monitor function and it is the exec function?

8:48 pm

Dara Navaei

I think it is a good practice to reset all the important variables that are defined as static in the .c file.

I think it is a good practice to reset all the important variables that are defined as static in the .c file.

8:41 pm

Dara Navaei

The states of the state machine should be private. This enum should be transferred to the .c file.

The states of the state machine should be private. This enum should be transferred to the .c file.

8:31 pm

Dara Navaei

A break is needed here.

A break is needed here.

8:30 pm

Dara Navaei

A break is needed here.

A break is needed here.