hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Apr 2021
7:33 pm

Sean Nash

Fixed merge conflicts. Fixed ADC config. Will fix ADC config on DEN-7605.

Options
    • -2
    • +2
    ./BloodFlow.c
  2. … 6 more files in changeset.
4:29 pm

Sean Nash

DEN-7605: publish alarm info.

Options
    • -2
    • +2
    ./Voltages.c
  2. … 1 more file in changeset.
2:18 pm

Sean Nash

DEN-7605: Added Dialin overrides to alarm info.

Options
    • -2
    • +2
    ./BloodFlow.c
  2. … 5 more files in changeset.
Thursday 15 Apr 2021
6:23 pm

Sean Nash

DEN-7605: Added new Voltage monitor module. Added new messaging and alarms for voltage monitor. Added messaging for alarm audio volume setting from UI.

Options
    • -0
    • +430
    ./Voltages.c
    • -0
    • +77
    ./Voltages.h
  3. … 9 more files in changeset.
4:07 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed code review comments

Options
    • -3
    • +3
    ./BloodLeak.c
  2. … 1 more file in changeset.
4:06 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

4:03 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:49 pm

qnguyen  (deleted user)

This should be compare to SELF_TEST_STATUS_PASSED now.

This should be compare to SELF_TEST_STATUS_PASSED now.

3:47 pm

qnguyen  (deleted user)

Recommend adding _MS to the end to indicate the metric in milliseconds.

Recommend adding _MS to the end to indicate the metric in milliseconds.

3:26 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed header needed change based on code review comment

Options
    • -1
    • +2
    ./BloodLeak.c
3:25 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:19 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Addressed code review comments

Options
    • -23
    • +49
    ./BloodLeak.c
    • -1
    • +1
    ./BloodLeak.h
  3. … 1 more file in changeset.
3:18 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:17 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:16 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:16 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:14 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:03 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:03 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

2:59 pm

pmontazemi  (deleted user)

No action item.

No action item.

2:58 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

2:58 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

2:57 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

Wednesday 14 Apr 2021
3:03 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

2:59 pm

pmontazemi  (deleted user)

No action item.

No action item.

2:54 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

Tuesday 13 Apr 2021
10:07 am

qnguyen  (deleted user)

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

8:57 am

Dara Navaei

Typecasting the variables is not needed here. The macro typecasts them.

Typecasting the variables is not needed here. The macro typecasts them.

8:52 am

Sean Nash

Should probably go to normal state on fail as well - otherwise you get stuck here in self-test state.

Should probably go to normal state on fail as well - otherwise you get stuck here in self-test state.

8:52 am

Dara Navaei

Can we clear this alarm when it is raised? If no, do we need this else statement? Because if the alarm has not been raised, we do not need to clear it either.

Can we clear this alarm when it is raised? If no, do we need this else statement? Because if the alarm has not been raised, we do not need to clear it either.