Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7860: Addressed code review comments

  1. … 1 more file in changeset.
We have not done this for any of the following features. After talking to Sean Nash, below is the TODO list. *HD Air Trap (TODO Sean Nash) *DG/HD Fluid Leak (DG TODO Sean Nash, HD TODO [~pmontaz...

We have not done this for any of the following features. After talking to Sean Nash, below is the TODO list.

  • HD Air Trap (TODO Sean Nash)
  • DG/HD Fluid Leak (DG TODO Sean Nash, HD TODO [~pmontazemi])
  • HD Blood Leak (TODO [~pmontazemi])
  • HD ADA/ADV Air Bubbles (TODO [~pmontazemi])
Addressed.

Addressed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7860: Addressed code review comments

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Addressed.

Addressed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Addressed.

Addressed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We plan on doing self-test as part of priming, so we confirm the bubble detector reads air on a new cartridge, then we check that we read fluid when we have completed priming. I need to add these c...

We plan on doing self-test as part of priming, so we confirm the bubble detector reads air on a new cartridge, then we check that we read fluid when we have completed priming. I need to add these checks. The air bubble detector alarm, however, should only be active during treatment (includes blood prime and rinseback), and outside of that we just monitor the detectors but never alarm. Therefore, we do not need to do the self-test in POST and it is fine to keep handleInitBubbleState(...) as is.

Note: No code change to handleInitBubbleState(...).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: disable syringe pump speed check if DISABLE_SYRINGE_ALARMS is defined.

  1. … 1 more file in changeset.
Addressed.

Addressed.

Addressed.

Addressed.

Compiler gives warnings with U32 casting, left code as is.

Compiler gives warnings with U32 casting, left code as is.

Addressed.

Addressed.

DEN-7860: Addressed code review comments

  1. … 1 more file in changeset.