hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jul 2021
5:26 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -4
    • +4
    ./Switches.c
    • -8
    • +1
    ./Switches.h
  3. … 1 more file in changeset.
1:08 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:03 pm

qnguyen  (deleted user)

Added additional functions.

Added additional functions.

1:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:41 pm

qnguyen  (deleted user)

Done.

Done.

12:41 pm

qnguyen  (deleted user)

Done.

Done.

12:36 pm

qnguyen  (deleted user)

It is both in develop branch and staging branch for fwcommon.

It is both in develop branch and staging branch for fwcommon.

11:39 am

Dara Navaei

DEN-9054 updated the build history log

Options
    • -1
    • +1
    ./Switches.c
  2. … 1 more file in changeset.
11:33 am

Dara Navaei

11:10 am

Dara Navaei

DEN-9054 tested the switches and non-volatile data management

Options
    • -50
    • +52
    ./Switches.c
  2. … 4 more files in changeset.
Wednesday 28 Jul 2021
11:54 am

Sean Nash

DEN-8886: Updated alarm audio volume levels. Extended watchdog recovery time to allow 24V to come back up. Changed safety line input pin from pull-up to pull-down config.

Options
    • -1
    • +1
    ./Bubble.c
    • -1
    • +1
    ./Valves.c
  3. … 6 more files in changeset.
Tuesday 27 Jul 2021
3:53 pm

Sean Nash

First sizeof() should have U32 (same as above).

First sizeof() should have U32 (same as above).

3:53 pm

Sean Nash

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

3:48 pm

Sean Nash

I think the data are floats, so 0 should be 0.0.

I think the data are floats, so 0 should be 0.0.

11:11 am

qnguyen  (deleted user)

Sent events only for changed settings.

Sent events only for changed settings.

11:04 am

qnguyen  (deleted user)

Set UF volume initially to 0 and removed this variable and related function.

Set UF volume initially to 0 and removed this variable and related function.

11:01 am

qnguyen  (deleted user)

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

10:54 am

qnguyen  (deleted user)

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).