Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8886: Added FPGA voltage monitoring and data publication.

  1. … 4 more files in changeset.
I moved this enum to DGDefs.h in HD-DEN-9054.

I moved this enum to DGDefs.h in HD-DEN-9054.

Why was this moved?

Why was this moved?

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

Caps?

Caps?

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

DEN-9054 added a check for the switch IDs

DEN-9054 addressed the code review comments

  1. … 1 more file in changeset.
RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

Added additional functions.

Added additional functions.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

It is both in develop branch and staging branch for fwcommon.

It is both in develop branch and staging branch for fwcommon.

DEN-9054 updated the build history log

  1. … 1 more file in changeset.