hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Aug 2021
11:18 am

Sean Nash

DEN-8886: second local merge from staging. Fixed merge conflicts.

Options
    • -2
    • +3
    ./PresOccl.c
  2. … 10 more files in changeset.
10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:52 am

Sean Nash

DEN-8886: Addressed code review comments.

Options
    • -2
    • +2
    ./DialInFlow.c
    • -1
    • +1
    ./DialOutFlow.c
    • -1
    • +2
    ./PresOccl.h
  4. … 5 more files in changeset.
8:50 am

Sean Nash

Done.

Done.

8:48 am

Sean Nash

Fixed.

Fixed.

8:47 am

Sean Nash

Fixed.

Fixed.

8:46 am

Sean Nash

Common.h includes TestSupport.h.

Common.h includes TestSupport.h.

8:45 am

Sean Nash

Added.

Added.

8:43 am

Sean Nash

Changed to match your implementation.

Changed to match your implementation.

8:38 am

Sean Nash

Usually. But this function is called by AlarmMgmt (not really a h/w driver) so I kept the conversion at FPGA level to keep it low level.

Usually. But this function is called by AlarmMgmt (not really a h/w driver) so I kept the conversion at FPGA level to keep it low level.

8:36 am

Sean Nash

Fixed.

Fixed.

8:34 am

Sean Nash

Done.

Done.

8:29 am

Sean Nash

Done.

Done.

Wednesday 18 Aug 2021
9:56 pm

Dara Navaei

Please mention the usage of this include.

Please mention the usage of this include.

9:56 pm

Dara Navaei

Please add the PN and the manufacturer of the sensors.

Please add the PN and the manufacturer of the sensors.

9:49 pm

Dara Navaei

The brief does not match with what the function does.

The brief does not match with what the function does.

9:38 pm

Dara Navaei

Was it not decided to just get the FPGA counts and then do the conversion into the driver that calls the FPGA function?

Was it not decided to just get the FPGA counts and then do the conversion into the driver that calls the FPGA function?

9:34 pm

Dara Navaei

If you merge staging into your branch, the temperatures driver converts all the temperature sensors and thermistors.

If you merge staging into your branch, the temperatures driver converts all the temperature sensors and thermistors.

9:32 pm

Dara Navaei

Missing doxygen comments.

Missing doxygen comments.