Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12224 addressed the code review comments

  1. … 2 more files in changeset.
Done.

Done.

The other states ignore this flag and I have to set it here since this is a request.

The other states ignore this flag and I have to set it here since this is a request.

For safety I do it here.

For safety I do it here.

Done

Done

Done

Done

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Removed the release check.

Removed the release check.

Done

Done

DEN-12224 updated the files

  1. … 1 more file in changeset.
Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Why isn't this command allowed for release version?

Why isn't this command allowed for release version?

Is this zero temporary? If so, add TODO.

Is this zero temporary? If so, add TODO.

I don't think we should exit normal mode in TreatmentStop sub-mode.

I don't think we should exit normal mode in TreatmentStop sub-mode.

Should we exit blood leak normal mode in here somewhere?

Should we exit blood leak normal mode in here somewhere?

Ask Behrouz if UI is still looking for this. Remove if not.

Ask Behrouz if UI is still looking for this. Remove if not.

Remove extra blank line. And why is there any blank line here?

Remove extra blank line. And why is there any blank line here?

Seems like we're setting a start time offset here, not a time stamp.

Seems like we're setting a start time offset here, not a time stamp.

Should be rpmAlarmStartTime

Should be rpmAlarmStartTime

Did we want this offset to revert to zero here or should Dialin have to do a reset?

Did we want this offset to revert to zero here or should Dialin have to do a reset?

I don't think this results in an elapsed time. It's just a different start time. The calcTimeSince below gives you the elapsed time.

I don't think this results in an elapsed time. It's just a different start time. The calcTimeSince below gives you the elapsed time.

DEN-12845 resolved merge conflicts during cherry picking process

  1. … 5 more files in changeset.
DEN-12847 Load cell drift check for stable reservoirs at full and empty.

  1. … 1 more file in changeset.
Should we set this flag only if we are in normal state?

Should we set this flag only if we are in normal state?

Remove extra blank line.

Remove extra blank line.