hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Dec 2022
5:06 pm

Michael Garthwaite

Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into develop

Options
    • -18
    • +112
    ./DialInFlow.c
5:05 pm

Michael Garthwaite

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

5:04 pm

Michael Garthwaite

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:01 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:01 pm

Michael Garthwaite

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to c...

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to change direction when the pump is on, both this condition and the one below will fail.

5:01 pm

Michael Garthwaite

DEN-14344: code review comments.

Options
    • -16
    • +15
    ./DialInFlow.c
  2. … 2 more files in changeset.
4:38 pm

Sean Nash

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

4:24 pm

Sean Nash

Where did this enum name change take place? There is no common in this code review.

Where did this enum name change take place? There is no common in this code review.

4:22 pm

Sean Nash

remove "," after pwm.

remove "," after pwm.

4:22 pm

Sean Nash

Remove blank line.

Remove blank line.

4:21 pm

Sean Nash

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

4:19 pm

Sean Nash

Remove blank line.

Remove blank line.

4:19 pm

Sean Nash

First part of condition should have () around it too. Do we want to set direction here even if we fail to satisfy condition below?

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

4:15 pm

Sean Nash

Keep a blank line between declaration and code.

Keep a blank line between declaration and code.

4:14 pm

Sean Nash

Not clear on what this refactoring of condition changed - looks the same.

Not clear on what this refactoring of condition changed - looks the same.

1:45 pm

Michael Garthwaite

Auto stash before merge of "develop" and "origin/develop"

Options
    • -0
    • +1
    ./AirPump.c
11:49 am

wbracken  (deleted user)

parameter0?

parameter0?

10:55 am

Dara Navaei

Please add comment.

Please add comment.

10:52 am

Dara Navaei

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
9:37 am

jtaylor  (deleted user)

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

9:33 am

Dara Navaei

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

Options
    • -1
    • +0
    ./DGInterface.c
9:32 am

Dara Navaei

DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

Options
    • -1
    • +0
    ./DGInterface.c
Thursday 01 Dec 2022
2:35 pm

Dara Navaei

Merged DEN-14252

Options
    • -2
    • +2
    ./DialInFlow.c
    • -1
    • +1
    ./SyringePump.c
  3. … 4 more files in changeset.
2:22 pm

Michael Garthwaite

DEN-14344: DPI set pwm direction fix.

Options
    • -13
    • +12
    ./DialInFlow.c
  2. … 1 more file in changeset.
1:42 pm

Sean Nash

DEN-14252: Candidate fix for DEN-14254 for syringe DAC issue.

Options
    • -1
    • +1
    ./SyringePump.c
  2. … 1 more file in changeset.