hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 4
Total Committers: 16
Last Commit: 11 May
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 05 Dec 2022
1:59 pm

Sean Nash

DEN-14344: Addressed code review comments.

Options
    • -1
    • +1
    ./DialInFlow.c
1:57 pm

Sean Nash

Removed.

Removed.

1:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:43 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH, no change

RESOLVED in CODE WALKTHROUGH, no change

1:41 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH, no change

RESOLVED in CODE WALKTHROUGH, no change

10:06 am

jtaylor  (deleted user)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

10:05 am

jtaylor  (deleted user)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

9:53 am

Sean Nash

Restore this blank line.

Restore this blank line.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 02 Dec 2022
5:44 pm

wbracken  (deleted user)

FIXED IN CODE WALKTHROUGH

FIXED IN CODE WALKTHROUGH

5:43 pm

wbracken  (deleted user)

Remove blank line.

Remove blank line.

5:06 pm

Michael Garthwaite

Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into develop

Options
    • -18
    • +112
    ./DialInFlow.c
5:05 pm

Michael Garthwaite

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

5:04 pm

Michael Garthwaite

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:01 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

5:01 pm

Michael Garthwaite

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to c...

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to change direction when the pump is on, both this condition and the one below will fail.

5:01 pm

Michael Garthwaite

DEN-14344: code review comments.

Options
    • -16
    • +15
    ./DialInFlow.c
  2. … 2 more files in changeset.