Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14561

Code review updates

  1. … 1 more file in changeset.
DEN-14604 updated the valves

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Need to verify SRS and AlarmsDef.h are in sync.

Need to verify SRS and AlarmsDef.h are in sync.

Alignment

Alignment

Comments line up but the values don't?

Comments line up but the values don't?

DEN-14549: Fix art/ven pressure alarm check logic - apply user set limits in dialysis state (if not saline bolus) or treatment stop state (if BP running). Require door/latch to be closed in patient connection state. Remove escalation for prime complete alarms. Handle prime complete alarms in pre-tx recirculate state. Update prime complete alarm properties.

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14557 addressed a code review comment

Done

Done

Should be or not and.

Should be or not and.

DEN-14557 reversed the blood leak's pass/fail logic in the zero sequence

HD-DEN-14557_Dvt 012 HD Valve Transition Time Out Valve Position Out OF Target During Cartridge
HD-DEN-14557_Dvt 012 HD Valve Transition Time Out Valve Position Out OF Target During Cartridge
DEN-14557 added code to the HD valves to accept a transition command if the valve is currently is not close to target

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Done.

Done.

Done.

Done.

Extra white space.

Extra white space.

Should align

Should align

If going back to start state, set pump track closed required, but not door closed. If skipping dry self-tests, set both to be required closed. Also, this s/w config looks like it's setup wrong. Fo...

If going back to start state, set pump track closed required, but not door closed. If skipping dry self-tests, set both to be required closed.

Also, this s/w config looks like it's setup wrong. For release build, we want to go back to start state.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.