hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Feb 2023
10:58 am

Michael Garthwaite

DEN-14589: fixed syringe pump events.

Options
    • -1
    • +1
    ./SyringePump.c
9:47 am

Sean Nash

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:47 am

Sean Nash

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement bel...

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

Thursday 02 Feb 2023
5:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:05 pm

Sean Nash

Do we understand why this is needed?

Do we understand why this is needed?

3:45 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AirPump.c
    • -2
    • +2
    ./AirTrap.c
    • -1
    • +1
    ./BloodFlow.c
    • -2
    • +2
    ./BloodLeak.c
    • -2
    • +2
    ./Bubble.c
    • -2
    • +2
    ./Buttons.c
    • -2
    • +2
    ./DGInterface.c
    • -2
    • +2
    ./DGInterface.h
    • -1
    • +1
    ./DialInFlow.c
    • -1
    • +1
    ./DialOutFlow.c
    • -2
    • +2
    ./PresOccl.c
    • -1
    • +1
    ./SyringePump.c
    • -2
    • +2
    ./Valves.c
    • -2
    • +2
    ./Voltages.c
  15. … 33 more files in changeset.
2:09 pm

wbracken  (deleted user) and dcox  (deleted user)

2:02 pm

Sean Nash

Fixed merge conflicts. Re-applied recently rolled back pre-tx state changes.

Options
    • -2
    • +3
    ./BloodFlow.c
    • -62
    • +38
    ./DGInterface.c
    • -3
    • +1
    ./DGInterface.h
    • -2
    • +4
    ./DialInFlow.c
    • -42
    • +21
    ./PresOccl.c
    • -2
    • +2
    ./SyringePump.c
  7. … 10 more files in changeset.
12:00 pm

Sean Nash

DEN-14549: Fixed merge from staging merge conflicts.

Options
    • -2
    • +2
    ./BloodLeak.c
    • -1
    • +13
    ./Buttons.c
    • -5
    • +7
    ./PresOccl.c
    • -11
    • +50
    ./Valves.c
  5. … 14 more files in changeset.
10:32 am

jtaylor  (deleted user)

Done.

Done.

10:30 am

jtaylor  (deleted user)

Done.

Done.

Wednesday 01 Feb 2023
4:44 pm

wbracken  (deleted user)

#define?

#define?

4:14 pm

wbracken  (deleted user)

Alignment

Alignment

4:13 pm

Michael Garthwaite

DEN-14556: updated alarm pressure occlusion alarm to 3s. HD now sends events when occlusion baseline is set. Alarm id 142 and 277 now send baseline occlusion value and trigger value.

Options
    • -4
    • +6
    ./PresOccl.c
3:41 pm

Michael Garthwaite

DEN-14589: implemented event for syringe pump state changes.

Options
    • -0
    • +6
    ./SyringePump.c
11:52 am

jtaylor  (deleted user)

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Tuesday 31 Jan 2023
6:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:45 pm

jtaylor  (deleted user)

Done. We will want to verify that we don't disable all of the resume fill calls.

Done. We will want to verify that we don't disable all of the resume fill calls.

3:42 pm

jtaylor  (deleted user)

Done.

Done.

1:30 pm

Sean Nash

What does flush complete have to do with draining here?

What does flush complete have to do with draining here?

1:26 pm

Sean Nash

We don't want to signal here if we don't have an air pump.

We don't want to signal here if we don't have an air pump.

1:14 pm

jtaylor  (deleted user)

Done.

Done.

1:05 pm

Sean Nash

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

1:00 pm

Sean Nash

Add blank line between declaration and code.

Add blank line between declaration and code.