Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14459: reverted code change due to code review comments.

Reverted. Thanks!

Reverted. Thanks!

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that...

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that to happen.

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

HD-DEN-14689_Messaging Bugs_HDFW
HD-DEN-14689_Messaging Bugs_HDFW
HD-DEN-14459_Air Trap Fill Alarm Not Triggering
HD-DEN-14459_Air Trap Fill Alarm Not Triggering
DEN-14459: fixed air trap control not returning on open valve state.

DEN-14273: Prevent certain DG alarms if AC power is lost (DEN-14550). Fix problem recovering from no cartridge installed alarm (DEN-14770).

  1. … 1 more file in changeset.
Merge branch 'DEN-14160-hd-blood-leak-override-not-working' into develop

  1. … 3 more files in changeset.
CORRECTED IN CODE WALKTHROUGH

CORRECTED IN CODE WALKTHROUGH

Done.

Done.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Merge branch 'DEN-14589-DIAL-211' into develop

  1. … 4 more files in changeset.
#define for 0

#define for 0

HD-DEN-14273_Gui Invalid Treatment Parameters Are Not Highlighted Red
HD-DEN-14273_Gui Invalid Treatment Parameters Are Not Highlighted Red
Fixed merge conflicts.

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14310 added code to not trigger the valves alarms if the HD power loss alarms are active

Fixed. Thanks!

Fixed. Thanks!

Merge branch 'staging' into DEN-14589-DIAL-211

DEN-14310 added code to prevent the trigger of the valves alarms in case any of the voltages alarms are active