hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Feb 2023
10:46 am

Michael Garthwaite

DEN-14459: code review comments

Options
    • -2
    • +7
    ./AirTrap.c
10:46 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:34 am

Sean Nash

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer ...

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer to reset things on entry (i.e. line 359 above).

10:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Michael Garthwaite

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other mode...

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other modes of operation. This counter is specifically here to hold the air pump on 100ms after upper level is detecting air. Should this check be moved to airpump.c?

10:22 am

Michael Garthwaite

DEN-14459: reverted code change due to code review comments.

Options
    • -0
    • +11
    ./AirTrap.c
10:22 am

Dara Navaei

10:21 am

Michael Garthwaite

Reverted. Thanks!

Reverted. Thanks!

10:11 am

Michael Garthwaite

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that...

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that to happen.

10:08 am

Sean Nash

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

10:06 am

Sean Nash

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Tuesday 14 Feb 2023
10:01 am

Dara Navaei

HD-DEN-14689_Messaging Bugs_HDFW
HD-DEN-14689_Messaging Bugs_HDFW
Monday 13 Feb 2023
4:01 pm

Dara Navaei

HD-DEN-14459_Air Trap Fill Alarm Not Triggering
HD-DEN-14459_Air Trap Fill Alarm Not Triggering
3:02 pm

Michael Garthwaite

DEN-14459: fixed air trap control not returning on open valve state.

Options
    • -13
    • +4
    ./AirTrap.c
Friday 10 Feb 2023
3:18 pm

Sean Nash

DEN-14273: Prevent certain DG alarms if AC power is lost (DEN-14550). Fix problem recovering from no cartridge installed alarm (DEN-14770).

Options
    • -21
    • +28
    ./DGInterface.c
    • -1
    • +1
    ./DialInFlow.c
    • -4
    • +8
    ./Fans.c
  4. … 1 more file in changeset.
2:44 pm

James Walter Taylor <jtaylor@diality.com>

Merge branch 'DEN-14160-hd-blood-leak-override-not-working' into develop

Options
    • -2
    • +2
    ./PresOccl.c
    • -2
    • +2
    ./SyringePump.c
  3. … 3 more files in changeset.
8:47 am

wbracken  (deleted user)

CORRECTED IN CODE WALKTHROUGH

CORRECTED IN CODE WALKTHROUGH

8:38 am

Sean Nash

Done.

Done.

8:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./PresOccl.c
    • -2
    • +2
    ./SyringePump.c
  3. … 5 more files in changeset.
8:10 am

Michael Garthwaite

Merge branch 'DEN-14589-DIAL-211' into develop

Options
    • -2
    • +4
    ./PresOccl.c
    • -0
    • +6
    ./SyringePump.c
  3. … 4 more files in changeset.
Thursday 09 Feb 2023
10:11 pm

Behrouz NematiPour

10:11 pm

Behrouz NematiPour

10:06 pm

wbracken  (deleted user)

#define for 0

#define for 0

6:01 pm

Dara Navaei

HD-DEN-14273_Gui Invalid Treatment Parameters Are Not Highlighted Red
HD-DEN-14273_Gui Invalid Treatment Parameters Are Not Highlighted Red
5:09 pm

Michael Garthwaite

5:07 pm

Sean Nash and dcox  (deleted user)

11:47 am

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./SyringePump.c
  2. … 2 more files in changeset.
11:23 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Valves.c
11:22 am

Dara Navaei

11:19 am

wbracken  (deleted user) , Sean Nash and Michael Garthwaite