Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-14689-messaging-bugs' into develop

  1. … 3 more files in changeset.
DEN-14689: message naming sync

  1. … 10 more files in changeset.
Fixed merge conflicts.

  1. … 1 more file in changeset.
DEN-13154: Update to handling of insufficient Heparin alarm per DEN-14814 and DEN-14287.

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration. RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration.
RESOLVED in CODE WALKTHROUGH.

1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state mac...

1. Style, and preference to keep loop control at the top, not buried in the state function.
2. Keep stack size for the state function more predictable.
3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state

Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide ...

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

I thought the non-safety temp alarms had a large persistence. Now they have none?

I thought the non-safety temp alarms had a large persistence. Now they have none?

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

Why move this?

Why move this?

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structur...

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structures to 1 byte (8-bit) alignment.

Can you clarify? Is U08 no longer the size of 1 byte?

Can you clarify? Is U08 no longer the size of 1 byte?

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Remove 2 blank lines.

Remove 2 blank lines.

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

2 lines appropriate around banner separators like this.

2 lines appropriate around banner separators like this.

Fixed merge conflicts.

  1. … 1 more file in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
HD-DEN-14830_Incorrect Dialysate Temperature Alarm Triggered
HD-DEN-14830_Incorrect Dialysate Temperature Alarm Triggered
DEN-14830: Fixed boolean logic for dialysate temperature alarms. Removed persistence counters for alarm 11 and 19 per PRS spec.

DEN-13154: Ensure alarm system has control of alarm lamp in fault mode in case fault occurred before lamp test completed. Do not request DG active alarms on startup if DG is not communicating.

  1. … 3 more files in changeset.