hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
1:41 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15104 Updates per code review.

Options
    • -5
    • +4
    ./Valves.c
  2. … 2 more files in changeset.
1:39 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:33 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:31 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

wbracken  (deleted user)

Removed

Removed

1:20 pm

wbracken  (deleted user)

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

1:16 pm

wbracken  (deleted user)

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.

1:15 pm

wbracken  (deleted user)

Removed.

Removed.

1:13 pm

wbracken  (deleted user)

Cut and paste error from DG. Corrected.

Cut and paste error from DG. Corrected.

1:07 pm

wbracken  (deleted user)

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

1:01 pm

wbracken  (deleted user)

Done

Done

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:44 am

wbracken  (deleted user)

Nothing else needs to be done.

Nothing else needs to be done.

11:11 am

Sean Nash

Remove blank line.

Remove blank line.

11:09 am

Sean Nash

Do we need to check for these in out exec?

Do we need to check for these in out exec?

11:07 am

Sean Nash

Are these used anywhere?

Are these used anywhere?

11:06 am

Sean Nash

Add space between ( and TRUE. Or just remove condition and always set flag to FALSE here.

Add space between ( and TRUE. Or just remove condition and always set flag to FALSE here.

11:03 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15104-hd-fpga-communications

# Conflicts:

# firmware/App/Controllers/BloodFlow.c

Options
    • -9
    • +5
    ./BloodFlow.c
    • -9
    • +5
    ./DialInFlow.c
    • -3
    • +3
    ./PresOccl.c
    • -4
    • +6
    ./Valves.c
  5. … 1 more file in changeset.
11:02 am

Sean Nash

Remove blank line.

Remove blank line.

11:01 am

Sean Nash

Use enums instead of literals.

Use enums instead of literals.

11:01 am

Sean Nash

Don't we have an enum for these values?

Don't we have an enum for these values?

10:58 am

Sean Nash

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

10:56 am

Sean Nash

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

10:55 am

Sean Nash

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

10:53 am

Sean Nash

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

10:46 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15014 Changes to support FPGA testing. Move FE and OE SCI faults to FPGA communications alarm.

Options
    • -1172
    • +1172
    ./BloodFlow.c
    • -2
    • +12
    ./BloodLeak.c
    • -1204
    • +1204
    ./DialInFlow.c
    • -1
    • +1
    ./PresOccl.c
    • -52
    • +49
    ./Valves.c
  6. … 4 more files in changeset.
10:35 am

Sean Nash

Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

10:34 am

Sean Nash

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

10:33 am

Sean Nash

Make U32.

Make U32.

10:07 am

Sean Nash

I think this whole function should be moved down into test support functions section.

I think this whole function should be moved down into test support functions section.