hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 May 2023
1:43 am

Behrouz NematiPour

Seems the only message which is providing the calculated A/V min/max is here in message 0x09. I think it was better to keep the min, max of the arterial and venous in the message 0x47 (A/V InTx adj...

Seems the only message which is providing the calculated A/V min/max is here in message 0x09.
I think it was better to keep the min, max of the arterial and venous in the message 0x47 (A/V InTx adj) to let UI immediately have the updated values,
instead of the x09 which is a broadcast and won't immediately send the updated/calculated min/max, and causes a short delay (depending on interval of the broadcast) to update the UI.
Or in both if the message 0x09 is getting continuously updated during treatment.

12:42 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

12:42 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

12:41 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Monday 29 May 2023
10:45 pm

Sean Nash

Fixed.

Fixed.

10:38 pm

Sean Nash

Fixed.

Fixed.

10:38 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:36 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:34 pm

Sean Nash

Fixed.

Fixed.

10:34 pm

Sean Nash

Fixed.

Fixed.

8:05 pm

Behrouz NematiPour

same here?

same here?

8:05 pm

Behrouz NematiPour

Isn't the Venous Asymmetric missing?

Isn't the Venous Asymmetric missing?

5:41 pm

Behrouz NematiPour

don't you need to add the venous asymmetric here to be reset? Since I am going to give user an option to adjust it during treatment.

don't you need to add the venous asymmetric here to be reset?
Since I am going to give user an option to adjust it during treatment.

1:52 pm

Behrouz NematiPour

12:17 am

wbracken  (deleted user)

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

12:16 am

wbracken  (deleted user)

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Saturday 27 May 2023
11:53 pm

wbracken  (deleted user)

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

11:51 pm

wbracken  (deleted user)

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

11:49 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Friday 26 May 2023
3:20 pm

jtaylor  (deleted user)

1:46 pm

Sean Nash

Will always be integers. Prefer to store them that way.

Will always be integers. Prefer to store them that way.

9:39 am

jtaylor  (deleted user)

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare ...

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare now; it's unclear whether they stop with AC returning or the operational state. Would we expect other operational impacts of operating from battery, or the loss and return of AC? Battery alarms, etc.?

The block timer runs from the time the condition clears in alarm management (cpld flag, or flag plus alarm state). If alarms are not included here, the timer may (probably will) time out with the alarm still active and the valves still improperly positioned. The valve position error will occur immediately after clearing the alarms, even with the alarms status checked in valves. The timer could be relocated to valves, but that doesn't take care of other sources of alarms after power recovery.

9:09 am

jtaylor  (deleted user)

this might be clearer written as: data = MAX( 0.0F, data )

this might be clearer written as: data = MAX( 0.0F, data )

Thursday 25 May 2023
11:44 am

wbracken  (deleted user)

Could these recently added variables be defined as F32 instead of casting?

Could these recently added variables be defined as F32 instead of casting?

Wednesday 24 May 2023
1:29 pm

Dara Navaei

HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
9:20 am

jtaylor  (deleted user)

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

Tuesday 23 May 2023
8:36 am

Sean Nash

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

8:35 am

Sean Nash

Do we need the alarm active checks? Isn't power loss check sufficient?

Do we need the alarm active checks? Isn't power loss check sufficient?

12:02 am

Dara Navaei

HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Monday 22 May 2023
1:40 pm

Michael Garthwaite