Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Merge branch 'DEN-15317-usability-hd-door-open-alarm-during-post-treatment' into develop

  1. … 2 more files in changeset.
Seems like we should be calling CPLD function here and in Fans, DialInFlow, and DGInterface too. Also recommend calling the isACPowerLost() function in just one place - maybe alarm mgmt exec to gi...

Seems like we should be calling CPLD function here and in Fans, DialInFlow, and DGInterface too.

Also recommend calling the isACPowerLost() function in just one place - maybe alarm mgmt exec to give you your 10 sec alarm block. Maybe rename the function to checkACPowerLost() with no return value and make it static (private).

It is a timer counter. Counts down to zero. And still need to address function header per Bill's first comment.

It is a timer counter. Counts down to zero.

And still need to address function header per Bill's first comment.

This seems unnecessary now with your new function doing this all the time. Consider removing.

This seems unnecessary now with your new function doing this all the time. Consider removing.

This is technically a timer counter based on task tick of 50ms.

This is technically a timer counter based on task tick of 50ms.

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

This was safer the other way. Why change?

How is this different than checking CPLD? Condition is cleared when CPLD no longer sees power loss (w/ 150ms delay I guess). Seems simpler to use CPLD function instead of checking 2 alarms.

How is this different than checking CPLD? Condition is cleared when CPLD no longer sees power loss (w/ 150ms delay I guess). Seems simpler to use CPLD function instead of checking 2 alarms.

Remove extra blank line.

Remove extra blank line.

DEN-15317: Fixed issue with failure to populate pressure limit state in the pressure data broadcast msg x9.

HD-DEN-15317_Usability HD Door Open Alarm During Post Treatment
HD-DEN-15317_Usability HD Door Open Alarm During Post Treatment
A 10 second timeout timer, driven by the 50ms tick that drives the alarm state machine.

A 10 second timeout timer, driven by the 50ms tick that drives the alarm state machine.

Add alarmsBlockedTimer to header. Is alarmsBlockedTimer a timer or is it a counter?

Add alarmsBlockedTimer to header. Is alarmsBlockedTimer a timer or is it a counter?

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power-4

Clear early initiation of block on cpld signal, HW recovery on release of cpld, SW recovery on alarm clear, normal alarm operation 10 seconds later.

  1. … 4 more files in changeset.
Merge branch 'DEN-15196-DIAL-258' into develop

  1. … 5 more files in changeset.
HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready
HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready
HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power
HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Merge branch 'DEN-15359-usability-arterial-and-venous-pressure-alarm-limits' into develop