hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Jun 2023
4:29 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power-4

Addressing last few new comments.

Options
    • -29
    • +27
    ./DGInterface.c
    • -32
    • +29
    ./DialInFlow.c
    • -32
    • +28
    ./DialOutFlow.c
    • -0
    • +4
    ./Valves.c
  5. … 1 more file in changeset.
4:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:16 pm

jtaylor  (deleted user)

Done. Error propagration.

Done. Error propagration.

4:11 pm

jtaylor  (deleted user)

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

4:05 pm

jtaylor  (deleted user)

Done.

Done.

4:01 pm

jtaylor  (deleted user)

Done.

Done.

3:12 pm

jtaylor  (deleted user)

Done.

Done.

3:07 pm

Sean Nash

Needs an else to zero out of range counter.

Needs an else to zero out of range counter.

3:04 pm

Sean Nash

This check is too far out. Each check function inside should check this with DG comm.

This check is too far out. Each check function inside should check this with DG comm.

2:59 pm

Sean Nash

Remove this condition.

Remove this condition.

2:58 pm

Sean Nash

Remove this condition.

Remove this condition.

2:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:45 pm

Sean Nash

Still need header fixed.

Still need header fixed.

2:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:30 pm

Sean Nash

Fixed merge conflicts from staging.

Options
    • -1
    • +1
    ./PresOccl.c
  2. … 2 more files in changeset.
2:04 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power-4

Comment updates.

Options
    • -8
    • +6
    ./Valves.c
2:04 pm

jtaylor  (deleted user)

Done.

Done.

1:52 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:52 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:51 pm

jtaylor  (deleted user)

We appear to need a delay from AC's return to the first alarm check. We have natural times at CPLD, Alarm clear, and the end of the alarm block interval. The alarm block timer currently clears 10 s...

We appear to need a delay from AC's return to the first alarm check. We have natural times at CPLD, Alarm clear, and the end of the alarm block interval. The alarm block timer currently clears 10 seconds after CPLD; the alarm is clear at a random interval from milliseconds to minutes after CPLD.
I have modified the calls for consistent use of CPLD or of isACPowerLost.

1:49 pm

jtaylor  (deleted user)

Done. The countdown timer was renamed for clarity.

Done. The countdown timer was renamed for clarity.

1:49 pm

jtaylor  (deleted user)

Done.

Done.

1:48 pm

jtaylor  (deleted user)

Renamed for clarification.

Renamed for clarification.

1:46 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:45 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power-4

Reponse to comments.

Options
    • -2
    • +1
    ./BloodFlow.c
    • -2
    • +2
    ./DGInterface.c
    • -2
    • +2
    ./DialInFlow.c
    • -1
    • +1
    ./DialOutFlow.c
    • -1
    • +1
    ./Fans.c
    • -1
    • +1
    ./Valves.c
  7. … 1 more file in changeset.