Activity hdfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 09 Aug 2023

10:03 am

Sean Nash

More
2e6fa60
changed 8 files
develop

Fixed merge conflicts.

- -1
- +1
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -17
- +17
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -0
- +1
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
- -1
- +0
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
- -2
- +2
./Temperatures.c
- History
- Source
- Diff
./Temperatures.c
… 3 more files in changeset.

10:02 am

Sean Nash

More
1b76127
changed 4 files
DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more HD-DENBUG-59-1

DENBUG-59: distinguish between alarms originating from outside.

- -2
- +2
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
… 3 more files in changeset.

Tuesday 08 Aug 2023

2:25 pm

Sean Nash

More
891cb02
changed 5 files
DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more HD-DENBUG-59-1

DENBUG-59: Addressed some unit test issues.

- -1
- +1
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -3
- +5
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
- -1
- +0
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
- -2
- +2
./Temperatures.c
- History
- Source
- Diff
./Temperatures.c
… 1 more file in changeset.

1:16 pm

Sean Nash

More
1281328
changed 5 files
DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more HD-DENBUG-59-1

DENBUG-59: Addressed some compiler warnings.

- -15
- +15
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -0
- +1
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
… 3 more files in changeset.

1:14 pm

Michael Garthwaite and Sean Nash

More
HD-DEN-15993-1
finished reviewing

11:29 am

Sean Nash

More
Re: HD-DEN-15993-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:24 am

wbracken (deleted user)

More
Re: HD-DEN-15993-1
replied to Sean Nash

Updated.

Updated.

10:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
03f1154
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 156 more HD-DEN-15993-1

DEN-15993 Make same logic change for cartridge level (AlarmID 85)

- -1
- +1
./Switches.c
- History
- Source
- Diff
./Switches.c

9:21 am

Sean Nash

More
HD-DEN-15741-2
Closed

8:37 am

Sean Nash

More
Re: HD-DEN-15993-1
commented on review

Need to do same for pump track latch.

Need to do same for pump track latch.

Monday 07 Aug 2023

2:29 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
225176b
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 156 more HD-DEN-15993-1

DEN-15993 Correct resume handling for front door

- -1
- +1
./Switches.c
- History
- Source
- Diff
./Switches.c

2:04 pm

Dara Navaei

More
HD-DEN-15993-1
started review

HD-DEN-15993_During Treatment Alarms 167 And Door And Latch Open Offer Resume Option That

HD-DEN-15993_During Treatment Alarms 167 And Door And Latch Open Offer Resume Option That

10:21 am

wbracken (deleted user)

More
HD-DEN-15741-2
finished reviewing

Friday 04 Aug 2023

6:02 pm

James Walter Taylor <jtaylor@diality.com>

More
7f9fd35
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more HD-DEN-15927-2

DEN-15927-alarm-127-low-venous-pressure-triggers-post-treatment-1

Remove unnecessary define

- -2
- +0
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

5:56 pm

James Walter Taylor <jtaylor@diality.com>

More
0b5c9a6
changed 1 file
develop

DEN-15927-alarm-127-low-venous-pressure-triggers-post-treatment-1

Removed unnecessary define.

- -2
- +0
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

5:47 pm

James Walter Taylor <jtaylor@diality.com>

More
6afab05
changed 1 file
develop

Merge remote-tracking branch 'origin/DEN-15927-alarm-127-low-venous-pressure-triggers-post-treatment-1' into develop

- -1
- +4
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

5:46 pm

James Walter Taylor <jtaylor@diality.com>

More
577c1ee
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more HD-DEN-15927-2

DEN-15927-alarm-127-low-venous-pressure-triggers-post-treatment-1

Incorporated state change, rather than flow.

- -1
- +2
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

5:40 pm

James Walter Taylor <jtaylor@diality.com>

More
6dc66bf
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more HD-UCOMMITS-25

DEN-15927-alarm-127-low-venous-pressure-triggers-post-treatment-1

Added a minimum flow requirement to provide a small additional margin to stabilize venous pressure.

- -1
- +3
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

3:49 pm

Sean Nash

More
HD-DEN-15741-2
finished reviewing

3:48 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:26 pm

jtaylor (deleted user)

More
Re: HD-DEN-15741-2
replied to Sean Nash

Wouldn't we want to stop if an alarm occurred during recirculation, which affected the blood circuit? My inclination would be to manage which alarms were enabled in this state rather than not imple...

Wouldn't we want to stop if an alarm occurred during recirculation, which affected the blood circuit? My inclination would be to manage which alarms were enabled in this state rather than not implement the mechanism to stop the pumps.

Implementing the change.
Done.

1:00 pm

Sean Nash

More
Re: HD-DEN-15741-2
commented on review

Should blood recirc blocked be based on alarm properties (as you've written here) or based on whether user stopped (specifically)? My feeling is that since there is no blood in blood side of circui...

Should blood recirc blocked be based on alarm properties (as you've written here) or based on whether user stopped (specifically)? My feeling is that since there is no blood in blood side of circuit (because rinseback was completed before we got to recirc), the NoBloodRecirc alarm property maybe doesn't apply here and we should only stop BP if the user stop alarm is active.

12:57 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:57 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:55 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:55 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:55 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

More
Re: HD-DEN-15741-2
commented on review

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

12:50 pm

jtaylor (deleted user)

More
Re: HD-DEN-15741-2
replied to Sean Nash

Done.

Done.

12:47 pm

Sean Nash

More
Re: HD-DEN-15741-2
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 09:58 -0700