hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Oct 2024
2:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:51 pm

Dara Navaei

Done

Done

2:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:48 pm

Sean Nash

You need to cast numerator and denominator as F32 or it doesn't really help.

You need to cast numerator and denominator as F32 or it doesn't really help.

2:40 pm

Dara Navaei

Removed it

Removed it

2:39 pm

Sean Nash

I don't think we need this field (been set). It will always be set.

I don't think we need this field (been set). It will always be set.

2:30 pm

Dara Navaei

Done

Done

2:30 pm

Dara Navaei

Done

Done

2:29 pm

Dara Navaei

Removed the #define

Removed the #define

2:29 pm

Dara Navaei

Done

Done

2:25 pm

Dara Navaei

Done

Done

2:24 pm

Dara Navaei

Done

Done

2:24 pm

Dara Navaei

Done

Done

2:04 pm

Sean Nash

I think we should do this on exit from self-test state on its way to normal.

I think we should do this on exit from self-test state on its way to normal.

1:58 pm

Sean Nash

Too complicated. Simplify.

Too complicated. Simplify.

1:47 pm

Sean Nash

upper and lower limits of range are BLD_NOMINAL_INTENSITY - ( setPoint * BLD_XXX_INTENSITY_OUT_OF_RANGE ).

upper and lower limits of range are BLD_NOMINAL_INTENSITY - ( setPoint * BLD_XXX_INTENSITY_OUT_OF_RANGE ).

1:44 pm

Sean Nash

I know I told you to do shift division, but I want a float for average so we need to do real division by sample count.

I know I told you to do shift division, but I want a float for average so we need to do real division by sample count.

1:35 pm

Sean Nash

Average should be a float. Allows much more precision. Reduces noise which is primary reason why we are doing a moving average.

Average should be a float. Allows much more precision. Reduces noise which is primary reason why we are doing a moving average.

1:33 pm

Sean Nash

This is too brief. Assume we want at least 3 samples to show below threshold. That's 12 seconds.

This is too brief. Assume we want at least 3 samples to show below threshold. That's 12 seconds.

1:31 pm

Sean Nash

This is a minimum interval, not "the" interval.

This is a minimum interval, not "the" interval.

1:31 pm

Sean Nash

Focus of name and comment should be on division by 16 - not on shift.

Focus of name and comment should be on division by 16 - not on shift.

1:28 pm

Sean Nash

Average should be float.

Average should be float.