Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

You need to cast numerator and denominator as F32 or it doesn't really help.

You need to cast numerator and denominator as F32 or it doesn't really help.

Removed it

Removed it

I don't think we need this field (been set). It will always be set.

I don't think we need this field (been set). It will always be set.

Done

Done

Done

Done

Removed the #define

Removed the #define

Done

Done

Done

Done

Done

Done

Done

Done

I think we should do this on exit from self-test state on its way to normal.

I think we should do this on exit from self-test state on its way to normal.

Too complicated. Simplify.

Too complicated. Simplify.

upper and lower limits of range are BLD_NOMINAL_INTENSITY - ( setPoint * BLD_XXX_INTENSITY_OUT_OF_RANGE ).

upper and lower limits of range are BLD_NOMINAL_INTENSITY - ( setPoint * BLD_XXX_INTENSITY_OUT_OF_RANGE ).

I know I told you to do shift division, but I want a float for average so we need to do real division by sample count.

I know I told you to do shift division, but I want a float for average so we need to do real division by sample count.

Average should be a float. Allows much more precision. Reduces noise which is primary reason why we are doing a moving average.

Average should be a float. Allows much more precision. Reduces noise which is primary reason why we are doing a moving average.

This is too brief. Assume we want at least 3 samples to show below threshold. That's 12 seconds.

This is too brief. Assume we want at least 3 samples to show below threshold. That's 12 seconds.

This is a minimum interval, not "the" interval.

This is a minimum interval, not "the" interval.

Focus of name and comment should be on division by 16 - not on shift.

Focus of name and comment should be on division by 16 - not on shift.

Average should be float.

Average should be float.