hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 Nov 2024
8:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 31 Oct 2024
8:16 pm

Dara Navaei

If a zero is requested, it is checked first and then this flag is reset. I also want this flag to be reset all the time so we do not zero on old reservoir.

If a zero is requested, it is checked first and then this flag is reset. I also want this flag to be reset all the time so we do not zero on old reservoir.

8:14 pm

Dara Navaei

This requests the blood zeroing and then the zeroing state machine does the flush prior to zeroing.

This requests the blood zeroing and then the zeroing state machine does the flush prior to zeroing.

5:59 pm

Sean Nash

Once reservoir switch occurs, do we have to wait until the "fresh" dialysate from new reservoir reaches the BLD?

Once reservoir switch occurs, do we have to wait until the "fresh" dialysate from new reservoir reaches the BLD?

5:58 pm

Sean Nash

This looks like it would reset the flag way too soon. Shouldn't flag reset be done in the resetBloodLeakZeroing() function?

This looks like it would reset the flag way too soon. Shouldn't flag reset be done in the resetBloodLeakZeroing() function?

5:40 pm

Dara Navaei

No it is not custom please look at systemcommmessages.

No it is not custom please look at systemcommmessages.

5:39 pm

Sean Nash

I thought this was going to be an indexed override like when you have an array of temp sensors and the index gives you the enum of the temp sensor you want to override. You have a BOOL flag instead...

I thought this was going to be an indexed override like when you have an array of temp sensors and the index gives you the enum of the temp sensor you want to override. You have a BOOL flag instead. Does that mean you're using a custom payload instead of the array override payload?

5:37 pm

Dara Navaei

Done

Done

5:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:36 pm

Sean Nash

Should be 2 blank lines above test support banner.

Should be 2 blank lines above test support banner.

5:36 pm

Sean Nash

Add comment explaining what we are checking here.

Add comment explaining what we are checking here.

5:35 pm

Dara Navaei

Done

Done

5:22 pm

Sean Nash

Move this too if you didn't already.

Move this too if you didn't already.

5:16 pm

Dara Navaei

Relocated the event.

Relocated the event.

5:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:13 pm

Dara Navaei

The drift timeout does not have an override it is the zeroing interval that has overrides.

The drift timeout does not have an override it is the zeroing interval that has overrides.

5:11 pm

Sean Nash

Sending event here is problematic now that we will likely defer zeroing until reservoir switch. It will send every 50ms until we finally zero. Move this to location where we are actually going to z...

Sending event here is problematic now that we will likely defer zeroing until reservoir switch. It will send every 50ms until we finally zero. Move this to location where we are actually going to zero OR just remove the event as its maybe no longer applicable.

5:09 pm

Sean Nash

I thought drift timeout (30 min) was overrideable. Looks like it's hard coded #define here.

I thought drift timeout (30 min) was overrideable. Looks like it's hard coded #define here.

5:08 pm

Sean Nash

Add a comment explaining we are resetting drift in range debounce timer if we are not in drift range.

Add a comment explaining we are resetting drift in range debounce timer if we are not in drift range.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:48 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:44 pm

Dara Navaei

The variables have been removed and/or renamed

The variables have been removed and/or renamed

4:43 pm

Dara Navaei

Removed the new varaible.

Removed the new varaible.

4:42 pm

Dara Navaei

Done

Done

4:41 pm

Sean Nash

Not really a range on upper side.

Not really a range on upper side.

4:40 pm

Sean Nash

Perhaps just a naming issue, but I can't figure out what these are for based on their name or comment.

Perhaps just a naming issue, but I can't figure out what these are for based on their name or comment.

11:05 am

Sean Nash

Why are we distinguishing between these 2 types of zeroes? Does it matter why we zeroed?

Why are we distinguishing between these 2 types of zeroes? Does it matter why we zeroed?

Wednesday 30 Oct 2024
10:11 pm

Dara Navaei

Per the Systems team the debounce time was set to 10 seconds.

Per the Systems team the debounce time was set to 10 seconds.