Drivers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14815: Switched to new CPLD based AC power loss check function.

  1. … 6 more files in changeset.
Add currentPostTreatmentState to header

Add currentPostTreatmentState to header

HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely
HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely
Merge branch 'DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power' into develop

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Oops. DeMorganized and done.

Oops. DeMorganized and done.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Remove space between ().

Remove space between ().

Add blank line between declaration and code. Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true. First conditio...

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.