Dialysis.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

If a zero is requested, it is checked first and then this flag is reset. I also want this flag to be reset all the time so we do not zero on old reservoir.

If a zero is requested, it is checked first and then this flag is reset. I also want this flag to be reset all the time so we do not zero on old reservoir.

This requests the blood zeroing and then the zeroing state machine does the flush prior to zeroing.

This requests the blood zeroing and then the zeroing state machine does the flush prior to zeroing.

Once reservoir switch occurs, do we have to wait until the "fresh" dialysate from new reservoir reaches the BLD?

Once reservoir switch occurs, do we have to wait until the "fresh" dialysate from new reservoir reaches the BLD?

This looks like it would reset the flag way too soon. Shouldn't flag reset be done in the resetBloodLeakZeroing() function?

This looks like it would reset the flag way too soon. Shouldn't flag reset be done in the resetBloodLeakZeroing() function?

No it is not custom please look at systemcommmessages.

No it is not custom please look at systemcommmessages.

I thought this was going to be an indexed override like when you have an array of temp sensors and the index gives you the enum of the temp sensor you want to override. You have a BOOL flag instead...

I thought this was going to be an indexed override like when you have an array of temp sensors and the index gives you the enum of the temp sensor you want to override. You have a BOOL flag instead. Does that mean you're using a custom payload instead of the array override payload?

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Should be 2 blank lines above test support banner.

Should be 2 blank lines above test support banner.

Add comment explaining what we are checking here.

Add comment explaining what we are checking here.

Done

Done

Move this too if you didn't already.

Move this too if you didn't already.

Relocated the event.

Relocated the event.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The drift timeout does not have an override it is the zeroing interval that has overrides.

The drift timeout does not have an override it is the zeroing interval that has overrides.

Sending event here is problematic now that we will likely defer zeroing until reservoir switch. It will send every 50ms until we finally zero. Move this to location where we are actually going to z...

Sending event here is problematic now that we will likely defer zeroing until reservoir switch. It will send every 50ms until we finally zero. Move this to location where we are actually going to zero OR just remove the event as its maybe no longer applicable.

I thought drift timeout (30 min) was overrideable. Looks like it's hard coded #define here.

I thought drift timeout (30 min) was overrideable. Looks like it's hard coded #define here.

Add a comment explaining we are resetting drift in range debounce timer if we are not in drift range.

Add a comment explaining we are resetting drift in range debounce timer if we are not in drift range.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The variables have been removed and/or renamed

The variables have been removed and/or renamed

Removed the new varaible.

Removed the new varaible.

Done

Done

Not really a range on upper side.

Not really a range on upper side.

Perhaps just a naming issue, but I can't figure out what these are for based on their name or comment.

Perhaps just a naming issue, but I can't figure out what these are for based on their name or comment.

Why are we distinguishing between these 2 types of zeroes? Does it matter why we zeroed?

Why are we distinguishing between these 2 types of zeroes? Does it matter why we zeroed?

Per the Systems team the debounce time was set to 10 seconds.

Per the Systems team the debounce time was set to 10 seconds.