Activity hdfirmware/firmware/App/Modes/ModePreTreat.c

3:29 pm

Michael Garthwaite

More
0339d83
changed 7 files
develop

Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into develop

- -2
- +2
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
… 6 more files in changeset.

2:05 pm

Dara Navaei

More
5ce2656
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more HD-DEN-14307-1 HD-DEN-14099-1 HD-DEN-14344-3

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
… 6 more files in changeset.

2:04 pm

jtaylor (deleted user) and Sean Nash

More
HD-DEN-14252-1
finished reviewing

1:43 pm

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

4:38 pm

Sean Nash

More
Re: HD-DEN-14252-1
replied to jtaylor (deleted user)

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

2:18 pm

Dara Navaei

More
e2649fa
changed 1 file
develop

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

- -1
- +1
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

2:14 pm

Sean Nash

More
71ecc11
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more HD-DEN-14252-1

DEN-14252: Another fix to pre-tx reservor mgmt state machine.

- -1
- +1
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

12:07 pm

Dara Navaei

More
ef228c1
changed 1 file
develop

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

- -1
- +1
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

12:03 pm

Sean Nash

More
80b0182
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more HD-DEN-14252-1

DEN-14252: Additional fix to reservoir mgmt state machine.

- -1
- +1
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

10:55 am

Dara Navaei

More
Re: HD-DEN-14344-3
commented on review

Please add comment.

9:37 am

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
commented on review

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

6:14 pm

Dara Navaei

More
bf0f9cc
changed 1 file
develop

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

- -1
- +4
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

6:13 pm

Dara Navaei

More
11fcffb
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more HD-DEN-14252-1

DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

- -1
- +4
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
… 1 more file in changeset.

2:35 pm

Dara Navaei

More
e408267
changed 6 files
develop

Merged DEN-14252

- -11
- +8
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
… 5 more files in changeset.

11:35 am

Sean Nash

More
06eb448
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more HD-DEN-14252-1

DEN-14252: Candidate fix for DEN-14252 bug.

- -11
- +8
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
… 1 more file in changeset.

4:17 pm

wbracken (deleted user)

More
Re: HD-DEN-14344-3
commented on review

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

4:05 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to wbracken (deleted user)

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

1:53 pm