hdfirmware / firmware / App / Modes

SelfTests.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Mar 2023
6:15 pm

Sean Nash

Merge branch 'DEN-13154-heparin-syringe-empty-position-incorrect' into develop

Options
    • -1
    • +9
    ./SelfTests.c
  2. … 1 more file in changeset.
6:14 pm

Sean Nash

DEN-13154: Further fix to DEN-14814 re: do not require syringe removal to re-do preload operation.

Options
    • -1
    • +9
    ./SelfTests.c
  2. … 1 more file in changeset.
4:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

Fixed.

Fixed.

11:36 am

Sean Nash

Fixed.

Fixed.

10:12 am

jtaylor  (deleted user)

Done.

Done.

10:11 am

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

Address comment

Options
    • -0
    • +1
    ./SelfTests.c
10:03 am

Sean Nash

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm. And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm. D...

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm.
And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm.
Did Systems want to separate these? My understanding was not to separate.

9:52 am

Sean Nash

Add blank line before return.

Add blank line before return.

9:41 am

jtaylor  (deleted user)

Friday 03 Mar 2023
11:35 am

Sean Nash

Fixed merge conflicts.

Options
    • -12
    • +4
    ./SelfTests.c
  2. … 1 more file in changeset.
11:28 am

Sean Nash

DEN-13154: Removed dry self-test timeout alarm. Fixed bug DEN-14884.

Options
    • -12
    • +4
    ./SelfTests.c
  2. … 2 more files in changeset.
Wednesday 01 Mar 2023
4:30 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14457-2_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

Checkpoint. Simplifying AIR_PUMP bug fix.

Options
    • -17
    • +11
    ./SelfTests.c
4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

10:01 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -3
    • +3
    ./SelfTests.c
  2. … 5 more files in changeset.
10:01 am

Michael Garthwaite

Merge branch 'staging' into DEN-14689-messaging-bugs

Options
    • -11
    • +35
    ./SelfTests.c
9:53 am

Michael Garthwaite

DEN-14689: message naming sync

Options
    • -2
    • +2
    ./SelfTests.c
  2. … 11 more files in changeset.
8:23 am

Sean Nash

Fixed merge conflicts.

Options
    • -9
    • +38
    ./SelfTests.c
  2. … 3 more files in changeset.
8:13 am

Sean Nash

DEN-13154: Update to handling of insufficient Heparin alarm per DEN-14814 and DEN-14287.

Options
    • -4
    • +33
    ./SelfTests.c
  2. … 2 more files in changeset.
Tuesday 28 Feb 2023
11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

I don't think it's necessary - but I'm ok with either location for declaration. RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration.
RESOLVED in CODE WALKTHROUGH.

9:38 am

jtaylor  (deleted user)

1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state mac...

1. Style, and preference to keep loop control at the top, not buried in the state function.
2. Keep stack size for the state function more predictable.
3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state

Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.

9:24 am

jtaylor  (deleted user)

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

Monday 27 Feb 2023
4:01 pm

Dara Navaei

HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    ./SelfTests.c
  2. … 1 more file in changeset.
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    ./SelfTests.c
  2. … 1 more file in changeset.
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    ./SelfTests.c
  2. … 1 more file in changeset.
11:40 am

Sean Nash

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide ...

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.

11:37 am

Michael Garthwaite

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?