TreatmentRecirc.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD-DEN-9906_HD Dev Flow Measurement Changes
HD-DEN-9906_HD Dev Flow Measurement Changes
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Removed.

Removed.

Adjust the space before the equal signs.

Adjust the space before the equal signs.

I adjusted spaces "before" the equal sign.

I adjusted spaces "before" the equal sign.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule. If you think it should be added to our standard, let's discuss.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule.
If you think it should be added to our standard, let's discuss.

Added comment.

Added comment.

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone. Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone.
Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

Why there are TBDs in the comments?

Why there are TBDs in the comments?

Outputs: Alarm may be activated

Outputs: Alarm may be activated

Some of local variables are not used in this function, consider removing them.

Some of local variables are not used in this function, consider removing them.

This should be an F64.

This should be an F64.