hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Apr 2021
10:37 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code review

Options
    • -0
    • +2
    ./ModePostTreat.c
    • -1
    • +1
    ./ModePreTreat.c
  3. … 1 more file in changeset.
10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

Only reverse when using == operator

Only reverse when using == operator

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:19 am

Dara Navaei

That is what I meant. Why are we even passing this when we know the target is 0?

That is what I meant. Why are we even passing this when we know the target is 0?

Sunday 25 Apr 2021
10:32 pm

qnguyen  (deleted user)

Added.

Added.

10:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code reviews

Options
    • -6
    • +24
    ./ModePostTreat.c
    • -1
    • +1
    ./ModePreTreat.c
  3. … 4 more files in changeset.
10:22 pm

qnguyen  (deleted user)

Changed to return none.

Changed to return none.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:17 pm

qnguyen  (deleted user)

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

10:14 pm

qnguyen  (deleted user)

Added.

Added.

10:12 pm

qnguyen  (deleted user)

I think the variable will be used in future to detect incorrect direction. Sean Nash Please elaborate more.

I think the variable will be used in future to detect incorrect direction.
Sean Nash Please elaborate more.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:09 pm

qnguyen  (deleted user)

The function has been removed.

The function has been removed.

10:08 pm

qnguyen  (deleted user)

Done.

Done.

8:24 pm

Dara Navaei

This function does not return anything.

This function does not return anything.

7:34 pm

Dara Navaei

This function needs a header.

This function needs a header.

7:33 pm

Dara Navaei

Is this function in charge of completely draining a reservoir? If yes, why should we provide a target parameter? Why not drain to 0 automatically?

Is this function in charge of completely draining a reservoir? If yes, why should we provide a target parameter? Why not drain to 0 automatically?

7:28 pm

Dara Navaei

This function needs a header.

This function needs a header.

7:05 pm

Dara Navaei

Do we need a fault here?

Do we need a fault here?

6:59 pm

Dara Navaei

Do we not need a fault here?

Do we not need a fault here?

6:44 pm

Dara Navaei

Will this variable be ever used?

Will this variable be ever used?

6:37 pm

Dara Navaei

For consistency, I recommend reversing the second part of and in the if statement.

For consistency, I recommend reversing the second part of and in the if statement.

6:37 pm

Dara Navaei

For consistency, I recommend reversing the second part of and in the if statement.

For consistency, I recommend reversing the second part of and in the if statement.

6:30 pm

Dara Navaei

As per our design decision, reverse the second part of the and.

As per our design decision, reverse the second part of the and.