hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Jul 2021
11:54 am

Sean Nash

DEN-8886: Updated alarm audio volume levels. Extended watchdog recovery time to allow 24V to come back up. Changed safety line input pin from pull-up to pull-down config.

Options
    • -2
    • +7
    ./ModeInitPOST.c
  2. … 7 more files in changeset.
Tuesday 27 Jul 2021
3:53 pm

Sean Nash

First sizeof() should have U32 (same as above).

First sizeof() should have U32 (same as above).

3:53 pm

Sean Nash

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

3:48 pm

Sean Nash

I think the data are floats, so 0 should be 0.0.

I think the data are floats, so 0 should be 0.0.

11:11 am

qnguyen  (deleted user)

Sent events only for changed settings.

Sent events only for changed settings.

11:04 am

qnguyen  (deleted user)

Set UF volume initially to 0 and removed this variable and related function.

Set UF volume initially to 0 and removed this variable and related function.

11:01 am

qnguyen  (deleted user)

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

10:54 am

qnguyen  (deleted user)

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

10:49 am

qnguyen  (deleted user)

Dara Navaei Please take a look.

Dara Navaei Please take a look.

10:49 am

qnguyen  (deleted user)

This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.

This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.

10:48 am

qnguyen  (deleted user)

Removed.

Removed.

10:38 am

qnguyen  (deleted user)

If fault mode calls the treatment log data collect function, the record can be zeroed also.

If fault mode calls the treatment log data collect function, the record can be zeroed also.

10:33 am

qnguyen  (deleted user)

The transition function will call this init function.

The transition function will call this init function.

10:29 am

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Addressed code review

Options
    • -6
    • +3
    ./ModePostTreat.c
    • -4
    • +21
    ./ModeTreatment.c
    • -16
    • +2
    ./ModeTreatmentParams.c
    • -1
    • +0
    ./ModeTreatmentParams.h
    • -1
    • +1
    ./Rinseback.c
  6. … 5 more files in changeset.
10:27 am

qnguyen  (deleted user)

Done.

Done.

10:25 am

qnguyen  (deleted user)

Fixed.

Fixed.

10:24 am

qnguyen  (deleted user)

Fixed.

Fixed.

10:19 am

qnguyen  (deleted user)

Done.

Done.

10:18 am

qnguyen  (deleted user)

The else is when AC power detected. Added clear alarm condition.

The else is when AC power detected. Added clear alarm condition.

Monday 26 Jul 2021
5:12 pm

Sean Nash

DEN-8886: Added UI compatibility POST test. Updated alarm audio per latest HDD. Added handling of UI and DG version messages. Fixed watchdog POST. Added recovery check to watchdog POST.

Options
    • -4
    • +0
    ./BloodPrime.h
    • -12
    • +43
    ./ModeInitPOST.c
    • -0
    • +2
    ./ModeInitPOST.h
  4. … 9 more files in changeset.
3:36 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

Options
    • -33
    • +169
    ./BloodPrime.c
    • -1
    • +1
    ./Dialysis.c
    • -13
    • +63
    ./ModeInitPOST.c
    • -0
    • +2
    ./ModePreTreat.c
    • -1
    • +1
    ./ModeTreatmentParams.c
  6. … 14 more files in changeset.
3:33 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

Options
    • -0
    • +4
    ./ModeInitPOST.c
    • -0
    • +4
    ./ModePreTreat.c
    • -0
    • +2
    ./ModeTreatment.c
    • -16
    • +22
    ./Prime.c
    • -0
    • +10
    ./SelfTests.c
  6. … 3 more files in changeset.
3:15 pm

Quang Nguyen <qnguyen@diality.com>

Remove pack for blood prime data

Options
    • -4
    • +0
    ./BloodPrime.h
    • -4
    • +0
    ./ModeInitPOST.c
  3. … 1 more file in changeset.
3:02 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8679-hd_dev-treatment-log' into develop

Options
    • -0
    • +6
    ./ModeInitPOST.c
  2. … 5 more files in changeset.
9:53 am

Sean Nash

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

9:50 am

Sean Nash

Not sure this variable (and related get function) are needed.

Not sure this variable (and related get function) are needed.

9:49 am

Sean Nash

User may not have changed all 4 settings. Should we only send events for those that actually changed?

User may not have changed all 4 settings. Should we only send events for those that actually changed?

9:41 am

Sean Nash

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

9:39 am

Sean Nash

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

9:34 am

Sean Nash

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.