Activity hdfirmware/firmware/App/Modes

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	10 Jun
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 02 Jun 2022

11:03 am

Michael Garthwaite

More
7498c77
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 325 more HD-DEN-12609-2

Merge branch 'staging' into DEN-12609-sw_dev-sprint-69_mg

- -35
- +97
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
- -2
- +3
./ModePreTreat.h
- History
- Source
- Diff
./ModePreTreat.h
… 2 more files in changeset.

Wednesday 01 Jun 2022

2:01 pm

Sean Nash

More
5501a43
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 330 more HD-DEN-12931-2

DEN-12931: Addressed bug DEN-12830.

- -1
- +1
./BloodPrime.c
- History
- Source
- Diff
./BloodPrime.c

Tuesday 31 May 2022

9:08 am

Sean Nash

More
24209d3
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 330 more HD-UCOMMITS-19

DEN-12931: Addressed bug DEN-12830.

- -1
- +1
./BloodPrime.c
- History
- Source
- Diff
./BloodPrime.c

Saturday 28 May 2022

10:09 pm

Dara Navaei

More
372f524
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 330 more HD-DEN-12931-2 HD-UCOMMITS-19

DEN-12931 updated VectorCAST and the messages to be able to parse them

- -0
- +7
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
… 2 more files in changeset.

Thursday 26 May 2022

10:28 am

Dara Navaei

More
HD-DEN-12224-16
Closed

10:27 am

Sean Nash

More
HD-DEN-12224-16
resumed reviewing

10:27 am

Dara Navaei

More
19a8bf9
changed 60 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 333 more HD-DEN-12845-2 HD-DEN-12847-1 HD-UCOMMITS-20

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./BloodPrime.c
- History
- Source
- Diff
./BloodPrime.c
- -2
- +2
./BloodPrime.h
- History
- Source
- Diff
./BloodPrime.h
- -1
- +1
./ConsumableSelfTest.c
- History
- Source
- Diff
./ConsumableSelfTest.c
- -2
- +2
./Dialysis.c
- History
- Source
- Diff
./Dialysis.c
- -2
- +2
./ModeFault.c
- History
- Source
- Diff
./ModeFault.c
- -2
- +2
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
- -1
- +1
./ModePostTreat.c
- History
- Source
- Diff
./ModePostTreat.c
- -2
- +2
./ModePostTreat.h
- History
- Source
- Diff
./ModePostTreat.h
- -2
- +2
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
- -1
- +1
./ModePreTreat.h
- History
- Source
- Diff
./ModePreTreat.h
- -1
- +1
./ModeService.c
- History
- Source
- Diff
./ModeService.c
- -1
- +1
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -2
- +2
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c
- -2
- +2
./ModeTreatment.h
- History
- Source
- Diff
./ModeTreatment.h
- -2
- +2
./ModeTreatmentParams.c
- History
- Source
- Diff
./ModeTreatmentParams.c
… 45 more files in changeset.

Wednesday 25 May 2022

11:06 am

Michael Garthwaite

More
HD-DEN-12224-16
resumed reviewing

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

Dara Navaei

More
Re: HD-DEN-12224-16
replied to Sean Nash

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:18 am

Dara Navaei

More
fe44ece
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 334 more HD-DEN-12224-16

DEN-12224 addressed the code review comments

- -1
- +0
./BloodPrime.c
- History
- Source
- Diff
./BloodPrime.c
- -1
- +0
./BloodPrime.h
- History
- Source
- Diff
./BloodPrime.h
… 1 more file in changeset.

10:17 am

Dara Navaei

More
Re: HD-DEN-12224-16
replied to Sean Nash

Done.

Done.

9:25 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatm...

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatment.

9:24 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

9:24 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

9:23 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Spaces between parenthesis and condition.

Spaces between parenthesis and condition.

9:22 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Space before final parenthesis.

Space before final parenthesis.

9:21 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Remove blank line.

Remove blank line.

9:21 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Should log volume level before and after.

Should log volume level before and after.

9:20 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

9:19 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Remove blank line.

Remove blank line.

Tuesday 24 May 2022

9:42 pm

Dara Navaei

More
HD-DEN-12845-2
started review

HD-DEN-12845_SW Dev Sprint S71 Steve

HD-DEN-12845_SW Dev Sprint S71 Steve

5:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-03 23:29 -0700