hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Jul 2022
2:34 pm

Sean Nash

DEN-13460: Updated arterial pressure limits range. Added actuators homing to standby start state.

Options
    • -1
    • +45
    ./ModeStandby.c
    • -1
    • +1
    ./ModeTreatmentParams.c
    • -1
    • +1
    ./SelfTests.c
  4. … 2 more files in changeset.
Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Friday 15 Jul 2022
2:21 pm

Michael Garthwaite

DEN-13427: Added events for wet self test results.

Options
    • -0
    • +4
    ./SelfTests.c
8:47 am

Dara Navaei

Merged staging and resolved the conflicts

Options
    • -1
    • +62
    ./Dialysis.c
    • -1
    • +1
    ./ModeInitPOST.c
    • -4
    • +1
    ./ModeStandby.c
    • -9
    • +9
    ./Rinseback.c
  5. … 4 more files in changeset.
Wednesday 13 Jul 2022
8:50 pm

Dara Navaei

8:49 pm

Sean Nash and Michael Garthwaite

8:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Dialysis.c
    • -1
    • +1
    ./ModeInitPOST.c
    • -1
    • +1
    ./ModeStandby.c
    • -2
    • +2
    ./Rinseback.c
  5. … 6 more files in changeset.
8:21 pm

Dara Navaei

DEN-12847 removed AC POST

Options
    • -8
    • +0
    ./ModeInitPOST.c
6:27 pm

Sean Nash

DEN-12931: Removed POST test for checking if booting from battery.

Options
    • -8
    • +0
    ./ModeInitPOST.c
5:19 pm

Sean Nash

DEN-12931: Refactored syringe detection alarm mgmt.

Options
    • -0
    • +3
    ./ModeFault.c
    • -12
    • +3
    ./ModePostTreat.c
    • -54
    • +4
    ./ModePreTreat.c
    • -1
    • +6
    ./ModeService.c
    • -0
    • +3
    ./ModeStandby.c
  6. … 2 more files in changeset.
4:25 pm

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:23 pm

Sean Nash

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Dara Navaei

DEN-12847 merged staging and addressed VectorCAST issues

Options
    • -2
    • +4
    ./Dialysis.c
    • -1
    • +1
    ./ModeStandby.c
    • -2
    • +2
    ./Rinseback.c
  4. … 6 more files in changeset.
12:59 pm

Sean Nash

DEN-12931: Refactored door and pump track alarm management.

Options
    • -0
    • +2
    ./BloodPrime.c
    • -0
    • +2
    ./Dialysis.c
    • -20
    • +5
    ./ModePostTreat.c
    • -24
    • +8
    ./ModePreTreat.c
    • -2
    • +5
    ./PreTreatmentRecirc.c
    • -0
    • +2
    ./Prime.c
    • -0
    • +2
    ./Rinseback.c
    • -16
    • +10
    ./SelfTests.c
    • -16
    • +10
    ./TreatmentEnd.c
    • -0
    • +2
    ./TreatmentRecirc.c
    • -0
    • +4
    ./TreatmentStop.c
  12. … 3 more files in changeset.
10:55 am

Dara Navaei

DEN-12847 addressed the code review comments and PiSquare's VectorCAST bugs

Options
    • -1
    • +0
    ./Dialysis.c
    • -8
    • +8
    ./Rinseback.c
  3. … 2 more files in changeset.
10:48 am

Dara Navaei

Done.

Done.

10:47 am

Dara Navaei

Done.

Done.

10:46 am

Dara Navaei

Done.

Done.

10:46 am

Dara Navaei

Done.

Done.

10:32 am

Sean Nash

I don't think this does what we want anymore. Need to revisit VC issue.

I don't think this does what we want anymore. Need to revisit VC issue.

10:25 am

Sean Nash

Remove blank line.

Remove blank line.

Tuesday 12 Jul 2022
3:20 pm

Sean Nash

indent of cases looks too small.

indent of cases looks too small.

3:20 pm

Sean Nash

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?