hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 07 Oct 2022
1:16 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Add response for Confirm Cancel. Fix parameters U32 value for Confirm messages.

Options
    • -0
    • +1
    ./ModeStandby.c
  2. … 1 more file in changeset.
10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:48 am

Sean Nash

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

10:35 am

Sean Nash

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

10:29 am

Sean Nash

Should add a break from loop here.

Should add a break from loop here.

10:25 am

Sean Nash

Convention is to ack when receiving one-shot (not broadcast) messages like this.

Convention is to ack when receiving one-shot (not broadcast) messages like this.

10:21 am

Sean Nash

Should break out of loop here I think.

Should break out of loop here I think.

10:19 am

Sean Nash

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

10:12 am

Sean Nash

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more norm...

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more normal functions down here too that should be moved.

10:04 am

Sean Nash

Change to "0 == disinfectCancelReqID"

Change to "0 == disinfectCancelReqID"

10:02 am

Sean Nash

Why absolute value?

Why absolute value?

9:59 am

Sean Nash

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

9:57 am

Sean Nash

Should add a comment for this (and maybe a #define). Looks like this value will prevail if measured RPM is zero so would expect infinite persist I guess - though shouldn't be calling this function ...

Should add a comment for this (and maybe a #define). Looks like this value will prevail if measured RPM is zero so would expect infinite persist I guess - though shouldn't be calling this function when pump is stopped I would think. Should probably be 8 Fs (not 7).

9:37 am

Sean Nash

Why don't we want to distinguish forward and reverse speeds with sign?

Why don't we want to distinguish forward and reverse speeds with sign?

9:35 am

Sean Nash

Is this reject from HD or user or both? Comment suggests from HD only.

Is this reject from HD or user or both? Comment suggests from HD only.

Thursday 06 Oct 2022
3:47 pm

wbracken  (deleted user)

GENERIC_CONFIGURE == disinfectCancelRegID

GENERIC_CONFIGURE == disinfectCancelRegID

3:42 pm

wbracken  (deleted user)

Does this need to handle lowercase hex characters and invalid characters?

Does this need to handle lowercase hex characters and invalid characters?

1:01 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

Options
    • -10
    • +24
    ./ModeStandby.c
  2. … 2 more files in changeset.
1:00 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Updated for HDDefs Confirm defines and updated parameters for confirm messages.

Options
    • -10
    • +24
    ./ModeStandby.c
  2. … 2 more files in changeset.
12:13 pm

Dara Navaei

DEN-13834 updated the semaphore

Options
    • -0
    • +3
    ./ModeFault.c
10:47 am

Sean Nash

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Tuesday 04 Oct 2022
5:53 pm

Sean Nash

Why not checking payload length?

Why not checking payload length?

5:52 pm

Sean Nash

Keep blank line.

Keep blank line.

5:48 pm

Sean Nash

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

5:43 pm

Sean Nash

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.

5:37 pm

Sean Nash

Why was blank line removed?

Why was blank line removed?

5:29 pm

Sean Nash

Align "=".

Align "=".

5:27 pm

Sean Nash

Add another blank line here.

Add another blank line here.

5:22 pm

Sean Nash

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.